Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Loc]The description text is not showing correctly in MultilineStringEditor drop down. #1076

Closed
Amy-Li02-zz opened this issue May 31, 2019 · 6 comments · Fixed by #1211 or #1264
Closed
Assignees
Labels
tenet-localization Suggested translations of resources; notification requiring translations; internationalization
Milestone

Comments

@Amy-Li02-zz
Copy link
Contributor

  • .NET Core Version: 3.0.100-preview6-012122 from Master branch
  • Have you experienced this same bug with .NET Framework?: No

Problem description:
The description text is not showing correctly in MultilineStringEditor drop down.

Issues Description Affected language
Issue#1 Description text is not showing in MultilineStringEditor drop down. TRK, CSY, JPN, FRA, KOR, PTB,PLK, DEU,
Issue#2 2 description sentences should be shown in 2 lines, need to wrap. CHS, CHT, RUS, ITA, ESN

Actual behavior:
Issue#1: Description text is not showing in MultilineStringEditor drop down.
Core
Issue#2: 2 description sentences doesn't wrap.
222

Expected behavior:
Description text should be show in MultilineStringEditor drop down, and 2 description sentences should be wrap.
Fra

Minimal repro:
1.Install latest VS & .NET Core 3.0 on loc machine, then open the attached app.
WindowsFormsApp2.zip
2.Run it and open the MultilineStringEditor drop down of Text property.

@Olina-Zhang
Copy link
Member

According to the commit: 023fd3d for testing, and found this issue.

@merriemcgaw merriemcgaw added the tenet-localization Suggested translations of resources; notification requiring translations; internationalization label Jun 13, 2019
@merriemcgaw
Copy link
Member

@zsd4yr Do you know what the loc status is for WinForms resources

@lukaschal
Copy link

lukaschal commented Jun 18, 2019

Issue#1 - String "MultilineStringEditorWatermark" is translated correctly in localization repository. See TRK example below.

https://github.com/dotnet/winforms/blob/master/src/System.Windows.Forms.Design.Editors/src/Resources/xlf/SR.tr.xlf

Rid="MultilineStringEditorWatermark"
source: Press Enter to begin a new line.\r\nPress Ctrl+Enter to accept Text.
target: Yeni satıra başlamak için Enter tuşuna basın.\r\nMetni kabul etmek için Ctrl+Enter tuşlarına basın.

@lukaschal
Copy link

Issue#2 - All strings has in a target added multiline by "\r\n" same as represented in a source.

@weltkante
Copy link
Contributor

weltkante commented Jun 18, 2019

Probably related to dotnet/wpf#977 - there is no response on the WPF issue yet, but if you get a fix here the WPF guys probably want to have it too.

@Amy-Li02-zz
Copy link
Contributor Author

Verified this issue in .Net Core 3.0.100-preview8-013096 from master branch, the 2 issues were fixed and in 13 local languages it all works well.
CHSCore
TRKCore

@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tenet-localization Suggested translations of resources; notification requiring translations; internationalization
Projects
None yet
6 participants