corrected line breaks within the file dialog resource strings.

[mjjames]

Fixes #977

I noticed in all of the other resource strings only \n is used not \r\n. Updated all of the file dialog resources to use \n instead of the \r\n.

[dnfclas]

All CLA requirements met.

[Gillibald]

Isn't the issue that \r\n isn't recognized as a line break? This is just hiding it. \r\n is totally valid on Windows.

[mjjames]

As part of this effort I did check that messagebox.show has no issues with the \r\n . I have made an assumption that the other resource entries are intentionally using just \n and they are doing so for a reason that I couldn’t immediately see. My initial investigation seemed to show everything looking correct for the other resource entries which is why the assumption was made that these had to be updated. One thing I hadn’t tried was the combination of string.format with messagebox.show nor using the get resource method and seeing if the issue laid in there instead. More than happy to be corrected if I have missed something else.

…

On 16 Jun 2019, at 22:05, Benedikt Schroeder ***@***.***> wrote: Isn't the issue that \r\n isn't recognized as a line break? This is just hiding it. \r\n is totally valid on Windows. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[weltkante]

I agree with @Gillibald this doesn't seem to be the right fix, see note on issue. If \n would work then you'd see a line break after the (literal) \r

Can you make sure you can reproduce the original bug without your fix?

[mjjames]

more than happy to abandon this PR then. The issue 100% does exist as is, my repo in the original bug filing shows the issue as does a bug raised on the Nuget Package Explorer repository NuGetPackageExplorer/NuGetPackageExplorer#705

[weltkante]

@mjjames I'm not saying the issue doesn't exist, I just would like to get to the root cause of the problem. So you are saying you can reproduce this bug with a custom WPF build using the original strings (to make sure the bug isn't already fixed in master) and the bug goes away after removing \r in the resource xml files and rebuilding? I don't have a custom WPF build setup currently, but I can try making one, to assist in debugging the root cause.

[stevenbrix]

@mjjames don't abandon this pr just yet. Do we know when this started happening? I'd be curious if this has been in WPF since we first ported it to core, or if something regressed along the way

[weltkante]

@stevenbrix its a general problem and also present in WinForms (see dotnet/winforms#1076)

As said before I don't think this PR fixes the issue, the problem is (probably) that nobody is translating C# escape sequences in XLF files, and that problem should be independent of \r\n vs \n issues

[weltkante]

#977 should have been fixed by #1285 so this PR probably can be dropped now, there should be no escape sequences left to replace