Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localized strings that render \r\n as text #1285

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

ryalanms
Copy link
Member

Problem description:
When you use an Open File Dialog and provide an invalid file OR if you use a Save File Dialog and try to overwrite an existing file the messagebox renders the \r\n as text instead of a line break.

See issue #977 for a full description.

Confirmed these updates fix File Dialog messages in English and German. (Fixes #977.)

@ghost ghost requested review from vatsan-madhavan, rladuca and stevenbrix July 16, 2019 19:23
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 16, 2019
@ghost ghost requested a review from SamBent July 16, 2019 19:23
Copy link
Member

@vatsan-madhavan vatsan-madhavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the translated files automatically adapt to this change while preserving the translated text?

Copy link
Member

@vatsan-madhavan vatsan-madhavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we do a global search for "\\r|\\n|\\r\\n" in .resx files and make sure that these are the only instances of this particular problem?

@vatsan-madhavan vatsan-madhavan added this to the 3.0 milestone Jul 16, 2019
@ryalanms
Copy link
Member Author

Did the translated files automatically adapt to this change while preserving the translated text?

No. The xlf generation doesn't touch translated strings (target), it only adds untranslated strings to the xlfs (translation unit, source, and target) and/or removes strings (translation units) from the xlfs. The translated strings (targets) in the xlfs need to be updated manually.

@ryalanms
Copy link
Member Author

Did we do a global search for "\\r|\\n|\\r\\n" in .resx files and make sure that these are the only instances of this particular problem?

Yes.

@ryalanms ryalanms merged commit 28bb9f7 into master Jul 16, 2019
@vatsan-madhavan vatsan-madhavan deleted the dev/ryalanms/filedialog_line_endings branch August 23, 2019 20:12
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Dialog messages that contain \r\n render the \r\n as text
2 participants