Cleanup GetSystemMetrics #1469
Merged
Cleanup GetSystemMetrics #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1469 +/- ##
===================================================
- Coverage 25.12242% 25.08664% -0.03578%
===================================================
Files 785 771 -14
Lines 268553 268936 +383
Branches 37959 37962 +3
===================================================
Hits 67467 67467
- Misses 196347 196731 +384
+ Partials 4739 4738 -1
|
zsd4yr
reviewed
Jul 25, 2019
zsd4yr
reviewed
Jul 25, 2019
RussKie
approved these changes
Jul 25, 2019
zsd4yr
reviewed
Jul 25, 2019
|
Just a few minor tweaks! In your defense, I looked at the old codebase and the order stuff was already present there :) Not sure for how long... |
zsd4yr
reviewed
Jul 25, 2019
|
All fixed |
zsd4yr
reviewed
Jul 26, 2019
src/System.Windows.Forms/src/System/Windows/Forms/SystemInformation.cs
Outdated
Show resolved
Hide resolved
JeremyKuhne
approved these changes
Jul 26, 2019
|
I'm reviewing it right now |
RussKie
requested changes
Jul 29, 2019
src/System.Windows.Forms/src/System/Windows/Forms/SystemInformation.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
📭 waiting-author-feedback
ghost
removed
the
📭 waiting-author-feedback
RussKie
approved these changes
Jul 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow