[WIP] Cleanup HWND related interop #1508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughbe
force-pushed
the
cleanup-window-interop
branch
from
15323f9 to
5a2877c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1508 +/- ##
===================================================
+ Coverage 25.94161% 25.98063% +0.03902%
===================================================
Files 807 836 +29
Lines 267786 267992 +206
Branches 37960 37953 -7
===================================================
+ Hits 69468 69626 +158
- Misses 193385 193436 +51
+ Partials 4933 4930 -3
|
|
Thanks @hughbe for this PR. We need to thoroughly validate these changes to make sure we are not regressing anything. Change pattern is straight but number of changes are huge. For core 3.0, We do not have app.config support for HDPI and validation of these changes need extra efforts. We can take this PR for 3.1. |
RussKie
reviewed
Jul 29, 2019
src/Common/src/Interop/User32/Interop.AreDpiAwarenessContextsEqual.cs
Outdated
Show resolved
Hide resolved
src/Common/src/Interop/User32/Interop.GetThreadDpiAwarenessContext.cs
Outdated
Show resolved
Hide resolved
src/Common/src/Interop/User32/Interop.GetThreadDpiAwarenessContext.cs
Outdated
Show resolved
Hide resolved
src/Common/src/Interop/User32/Interop.SetThreadDpiAwarenessContext.cs
Outdated
Show resolved
Hide resolved
src/Common/src/Interop/User32/Interop.SetThreadDpiAwarenessContext.cs
Outdated
Show resolved
Hide resolved
src/Common/src/Interop/User32/Interop.SetThreadDpiAwarenessContext.cs
Outdated
Show resolved
Hide resolved
hughbe
force-pushed
the
cleanup-window-interop
branch
3 times, most recently
from
42f4a1f to
873cbda
Compare
RussKie
reviewed
Jul 30, 2019
...ystem.Windows.Forms.Design/tests/UnitTests/System/ComponentModel/Design/DesignerHostTests.cs
Outdated
Show resolved
Hide resolved
hughbe
force-pushed
the
cleanup-window-interop
branch
2 times, most recently
from
873cbda to
e2b1320
Compare
RussKie
added
🚫 * NO-MERGE *
hughbe
force-pushed
the
cleanup-window-interop
branch
from
e2b1320 to
87dbcd5
Compare
ghost
removed
the
📭 waiting-author-feedback
hughbe
force-pushed
the
cleanup-window-interop
branch
from
87dbcd5 to
d001919
Compare
This was referenced Aug 7, 2019
Merged
RussKie
reviewed
Aug 8, 2019
| @@ -74,8 +74,8 @@ public class CheckedListBox : ListBox | |||
|
|
|||
| static CheckedListBox() | |||
| { | |||
| LBC_GETCHECKSTATE = SafeNativeMethods.RegisterWindowMessage("LBC_GETCHECKSTATE"); | |||
| LBC_SETCHECKSTATE = SafeNativeMethods.RegisterWindowMessage("LBC_SETCHECKSTATE"); | |||
| LBC_GETCHECKSTATE = Interop.User32.RegisterWindowMessageW("LBC_GETCHECKSTATE"); | |||
There was a problem hiding this comment.
@JeremyKuhne previously we had safe and unsafe native methods segregated, with all the refactoring and cleanup work (incl. this one) we're loosing this distinction.
Is this something we need to be concerned with?
There was a problem hiding this comment.
Is this something we need to be concerned with?
No. It isn't a pattern that makes sense with CAS gone. https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1060-move-p-invokes-to-nativemethods-class?view=vs-2019
RussKie
added
the
📭 waiting-author-feedback
hughbe
changed the title
ghost
removed
the
📭 waiting-author-feedback
hughbe
force-pushed
the
cleanup-window-interop
branch
2 times, most recently
from
3b2443b to
8a92483
Compare
hughbe
force-pushed
the
cleanup-window-interop
branch
from
8a92483 to
6c2e07f
Compare
hughbe
force-pushed
the
cleanup-window-interop
branch
from
6c2e07f to
4973b41
Compare
RussKie
removed
the
🚫 * NO-MERGE *
|
Closing this temporarily. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow