Fix order of AVPlayerWrapperState.state #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the order of Event.PlaybackState events on RNTP were off.
Following is a screen recording of an example app I made to demonstrate the issue:
RPReplay_Final1661349443.MP4
(Note that the missing 'buffering' event after the first execution of
TrackPlayer.add
is due to doublesymmetry/react-native-track-player#1672)Note that in the screen recording you see the following Event.PlaybackState logs after the second reset / add / play:
buffering
none
buffering
ready
buffering
playing
while it should be:
buffering
ready
playing
as seen in the screen recording with this fix implemented:
RPReplay_Final1661343206.MP4