Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of AVPlayerWrapperState.state #21

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

puckey
Copy link
Contributor

@puckey puckey commented Aug 24, 2022

I noticed that the order of Event.PlaybackState events on RNTP were off.
Following is a screen recording of an example app I made to demonstrate the issue:

RPReplay_Final1661349443.MP4

(Note that the missing 'buffering' event after the first execution of TrackPlayer.add is due to doublesymmetry/react-native-track-player#1672)

Note that in the screen recording you see the following Event.PlaybackState logs after the second reset / add / play:

buffering
none
buffering
ready
buffering
playing

while it should be:

buffering
ready
playing

as seen in the screen recording with this fix implemented:

RPReplay_Final1661343206.MP4

@dcvz dcvz merged commit 72f9c5d into doublesymmetry:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants