Use KafkaProtocol to handle serialization/deserialization of api events #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need more concentration for the review, will get it done on weekend. I like the idea, more async like interface. |
|
We can probably make the |
tvoinarovskyi
approved these changes
Oct 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further work toward Issue #560 . Following from PR #1032, this moves the translation of api request/response events to and from network IO bytes into an independent class, KafkaProtocol.
This class is intended to be reusable between different approaches to socket handling / networking. This approach should also enable simplified unit testing of protocol-level code (though actual test updates are left for future PRs).