Fix SASL authentication bugs #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need tests for the SASL code. So many issues already ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes three bugs in sasl handshake processing: First, after #1230 _recv() does not handle futures / in-flight-request processing. We need to call self.recv() if we want callbacks to be triggered automatically. Second, it is possible that recv() may catch a network error and close the connection. This will reset _sasl_auth_future and so we need to validate that it is not None before checking if it failed or succeeded. Third, when processing the SaslHandShakeResponse we should validate that the configured sasl_mechanism is listed as enabled in the handshake response.
In addition, I have consolidated the socket send routine into a single private method, _send_bytes_blocking(data).
Fixes #1255