Give better struct errors #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
better-struct-errors
branch
from
6b7aabd to
60f5d5f
Compare
Stop shadowing the word `error` because we want to know what the specific exception message was. Also give more details on exactly which value failed. We don't know who submitted the value, but perhaps it's unique enough that we can debug it better. Fix #1318
jeffwidman
force-pushed
the
better-struct-errors
branch
from
60f5d5f to
54f12d4
Compare
| raise ValueError(error) | ||
| except error as e: | ||
| raise ValueError("Error encountered when attempting to convert value: " | ||
| "{} to struct format: '{}', hit error: {}" |
There was a problem hiding this comment.
Maybe {!r} for value just in case str is overridden.
There was a problem hiding this comment.
I forgot to do this earlier, changed in #1373
|
Looks good. |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop shadowing the word
errorbecause we want to know what the specific exception message was.Also give more details on exactly which value failed. We don't know who submitted the value, but perhaps it's unique enough that we can debug it better.
Fix #1318