-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of struct errors doesn't print the specific error message #1318
Comments
This was referenced Dec 8, 2017
jeffwidman
added a commit
that referenced
this issue
Dec 8, 2017
Stop shadowing the word `error` because we want to know what the specific exception message was. Also give more details on exactly which value failed. We don't know who submitted the value, but perhaps it's unique enough that we can debug it better. Fix #1318
jeffwidman
added a commit
that referenced
this issue
Dec 8, 2017
Stop shadowing the word `error` because we want to know what the specific exception message was. Also give more details on exactly which value failed. We don't know who submitted the value, but perhaps it's unique enough that we can debug it better. Fix #1318
jeffwidman
added a commit
that referenced
this issue
Dec 8, 2017
Stop shadowing the word `error` because we want to know what the specific exception message was. Also give more details on exactly which value failed. We don't know who submitted the value, but perhaps it's unique enough that we can debug it better. Fix #1318
jeffwidman
changed the title
Handling of struct errors seems uneccessarily confusing and complex
Handling of struct errors doesn't print the specific error message
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a
struct.error
is thrown during_pack()
or_unpack()
, we catch and re-raise as aValueError
: https://github.com/dpkp/kafka-python/blob/master/kafka/protocol/types.py#L11-L12However, we're shadowing the word
error
so we lose a handle on the specific exception and cannot print the specific error message.The text was updated successfully, but these errors were encountered: