changed markdown parser #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| title: breadcrumb.title | ||
| ? markdownit.renderInline(breadcrumb.title) | ||
| : UNTITLED_TEXT | ||
| title: breadcrumb.title ? breadcrumb.title : UNTITLED_TEXT |
There was a problem hiding this comment.
Just sanity checking - you don't want rendered markdown in breadcrumbs?
There was a problem hiding this comment.
i'm passing the title as-is and markdownifying it in the breadcrumbs module
| <ReactMarkdown | ||
| source={ | ||
| teachingGuide.hasPart.find(item => item.name === "Questions") | ||
| .text |
There was a problem hiding this comment.
Did you want to allow for emphasis here?
| "/primary-source-sets/" | ||
| ) | ||
| ) | ||
| }} | ||
| /> |
There was a problem hiding this comment.
Did you want to allow emphasis in the above ReactMarkdown?
There was a problem hiding this comment.
yes and it is because all types are allowed by default. emphasis is specified in the cases where we only want emphasis to show up
| source={ | ||
| teachingGuide.hasPart.find(item => item.name === "Activity") | ||
| .text | ||
| } |
| set.hasPart.find(item => item.name === "Resources").text | ||
| ) | ||
| }} | ||
| source={set.hasPart.find(item => item.name === "Resources").text} |
AudreyAltman
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this and most future fixes will collide with #803 so it is preferrable to merge that branch sooner rather than later
now using react-markdown for all markdown needs... also allows us to do custom link rendering for issues like #783
fixes #523