Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded next / SASS support #803

Merged
merged 31 commits into from
Apr 13, 2018
Merged

upgraded next / SASS support #803

merged 31 commits into from
Apr 13, 2018

Conversation

mgiraldo
Copy link
Contributor

@mgiraldo mgiraldo commented Apr 7, 2018

this is going to be one of those massive branches because it will affect every html file in the repo so i decided to make this first push

  • upgraded to next 5.1
  • added support to sass while still using the old postcss which i am deprecating (this was the hardest thing to figure out... how to have both coexist for now)
  • migrated the header and footer from postcss to sass

main advantages:

  • being in the latest version of next
  • will eventually get rid of the skeleton-loader module
  • simplify the deployment process when we remove many postcss-related modules once the migration is complete
  • less use of dangerouslySetInnerHTML
  • source mapping working (not there yet but should be eventually)
  • better syntax checking in IDE

Copy link
Contributor

@mdellabitta mdellabitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, source mapping working

@mgiraldo
Copy link
Contributor Author

ok i'm done with the last set of migrations:

  • no more warnings related to versions of packages having “unmet peer dependencies”
  • latest carousel version (remember when it was right-aligned? upgrading everything seems to have fixed that, see also above)
  • no more postcss \o/
  • source maps working! 🎉
  • all the benefits of next 5.1

@mgiraldo
Copy link
Contributor Author

could @mdellabitta @AudreyAltman @markbreedlove someone give this an additional sanity check before i merge? basically clicking around making sure things work fine.

@mgiraldo mgiraldo mentioned this pull request Apr 12, 2018
@mdellabitta
Copy link
Contributor

I clicked around on my local and things looked good.

@mgiraldo mgiraldo merged commit 10e7a2d into master Apr 13, 2018
@mgiraldo mgiraldo deleted the next5 branch April 13, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants