Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

Undefined rule font-family-no-missing-generic-family-keyword #8

Open
eldair opened this issue Dec 29, 2017 · 6 comments
Open

Undefined rule font-family-no-missing-generic-family-keyword #8

eldair opened this issue Dec 29, 2017 · 6 comments

Comments

@eldair
Copy link

eldair commented Dec 29, 2017

Started getting error Undefined rule font-family-no-missing-generic-family-keyword on format after updating stylelint-config-standard, probably outdated stylelint version?

@mstanaland
Copy link

I'm trying to get started with prettier-stylelint, and I'm getting the same error. Was thinking I had a bad config, but maybe there is bug or incompatible versions.

My stylelint.config.js is pretty basic:

module.exports = {
  extends: [
    "stylelint-config-recommended-scss",
    "./node_modules/prettier-stylelint/config.js"
  ]
};

And here's the error it throws for each file:

Error: Undefined rule font-family-no-missing-generic-family-keyword
    at module.exports (/Users/mstanaland/Desktop/account-react/node_modules/stylelint/lib/utils/configurationError.js:8:27)
    at Object.keys.forEach.ruleName (/Users/mstanaland/Desktop/account-react/node_modules/stylelint/lib/augmentConfig.js:278:13)
    at Array.forEach (<anonymous>)
    at normalizeAllRuleSettings (/Users/mstanaland/Desktop/account-react/node_modules/stylelint/lib/augmentConfig.js:274:29)
    at augmentConfigBasic.then.then.then.then.augmentedConfig (/Users/mstanaland/Desktop/account-react/node_modules/stylelint/lib/augmentConfig.js:83:12)
    at <anonymous>

@jeddy3
Copy link

jeddy3 commented Dec 29, 2017

Try npm --depth 1 update.

font-family-no-missing-generic-family-keyword was introduced in stylelint@8.3.0 and this package does have a dependency range that includes that version.

(This probably won't work if use yarn as the lockfile pins stylelint to 8.1.1. I believe a new version of this package will need to be published if it wishes to be compatible with the stylelint version of config-standard and config-recommended.)

@MarkSky
Copy link

MarkSky commented Feb 2, 2018

I have the same error :Undefined rule font-family-no-missing-generic-family-keyword, when set font-family-no-missing-generic-family-keyword": true, in .stylelintrc file.

@timhecker
Copy link

Any news about this?

@eldair
Copy link
Author

eldair commented Mar 7, 2018

This is a huge pain, we have to manually run npm --depth 1 update each time a parent package updates.

@timhecker
Copy link

Thanks, but I'm a yarn user: I'm waiting for some update in VScode stylelint extension.

mgiraldo added a commit to dpla/dpla-frontend that referenced this issue Apr 13, 2018
* 👾 hello world postcss + sass \o/

* 👾 header and footer in scss

* 👾 added scss folder

* 👾 removed comments

* 👾 object.entries polyfill for ie11

* 👾 remove onAppUpdated since it is deprecated in next5

* 👾 refactored error, pages, some components

* 👾 done with utils.css

* 👾 a whole new batch of migrated css

* 👾 another batch of migrations

* 👾 refresh?

* 👾 back with lint

* 👾 utilfunctions is back

* 👾 removed titlecase (unused)

* 👾 test is back

* 👾 selenium lib is back

* 👾 with source maps / minor fixes / no extra packages

* 👾 upgraded react-slick / minor fixes

* 👾 added scss linter

* 👾 fixed precommit hook

* 👾 fixed precommit hook

* 👾 linted all scss

* 👾 removed stylelint-config-standard because hugomrdias/prettier-stylelint#8

* 👾 fixed remnant css var / fixed breadcrumb alignment

* 👾 version bump

* 👾 added yarn step to analyzer

* 👾 with next bundle analyzer
mgiraldo added a commit to dpla/dpla-frontend that referenced this issue Apr 17, 2018
* 👾 hello world postcss + sass \o/

* 👾 header and footer in scss

* 👾 added scss folder

* 👾 removed comments

* 👾 object.entries polyfill for ie11

* 👾 remove onAppUpdated since it is deprecated in next5

* 👾 refactored error, pages, some components

* 👾 done with utils.css

* 👾 a whole new batch of migrated css

* 👾 another batch of migrations

* 👾 refresh?

* 👾 back with lint

* 👾 utilfunctions is back

* 👾 removed titlecase (unused)

* 👾 test is back

* 👾 selenium lib is back

* 👾 with source maps / minor fixes / no extra packages

* 👾 upgraded react-slick / minor fixes

* 👾 added scss linter

* 👾 fixed precommit hook

* 👾 fixed precommit hook

* 👾 linted all scss

* 👾 removed stylelint-config-standard because hugomrdias/prettier-stylelint#8

* 👾 fixed remnant css var / fixed breadcrumb alignment

* 👾 version bump

* 👾 added yarn step to analyzer

* 👾 with next bundle analyzer

* 👾 now with separate printable guide

* 👾 eliminated some globals

* 👾 removed unused classes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants