Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glitches with new css #811

Merged
merged 35 commits into from
Apr 17, 2018
Merged

glitches with new css #811

merged 35 commits into from
Apr 17, 2018

Conversation

mgiraldo
Copy link
Contributor

there were some issues with the carousels with the new css because before we were using a lot of :global scopes

mgiraldo added 30 commits April 6, 2018 16:41
@mgiraldo
👾 hello world postcss + sass \o/
1c3a161
@mgiraldo
👾 header and footer in scss
7db1a2b
@mgiraldo
👾 added scss folder
305b024
@mgiraldo
👾 removed comments
fa521cf
@mgiraldo
👾 object.entries polyfill for ie11
b220bfb
@mgiraldo
👾 remove onAppUpdated since it is deprecated in next5
6c38f5b
@mgiraldo
Merge branch 'master' into next5
00901da
@mgiraldo
Merge branch 'master' into next5
fcd2842
@mgiraldo
👾 refactored error, pages, some components
7cff4db
@mgiraldo
👾 done with utils.css
35f469b
@mgiraldo
👾 a whole new batch of migrated css
0d4c9d5
@mgiraldo
👾 another batch of migrations
030a49e
@mgiraldo
👾 refresh?
ac067d6
@mgiraldo
👾 back with lint
64f2b56
@mgiraldo
👾 utilfunctions is back
e45fb30
@mgiraldo
👾 removed titlecase (unused)
5d5c4ef
@mgiraldo
👾 test is back
6526491
@mgiraldo
👾 selenium lib is back
0e03c51
@mgiraldo
👾 with source maps / minor fixes / no extra packages
f7d5cd6
@mgiraldo
👾 upgraded react-slick / minor fixes
99482ef
@mgiraldo
Merge branch 'master' into next5
2082159
@mgiraldo
👾 added scss linter
3e2ebdb
@mgiraldo
👾 fixed precommit hook
a8f9cd1
@mgiraldo
👾 fixed precommit hook
2344b51
@mgiraldo
👾 linted all scss
ea0329a
@mgiraldo
👾 removed stylelint-config-standard because hugomrdias/prettier-style…
a8b5739 
…lint#8
@mgiraldo
👾 conflict resolution
be81f82
@mgiraldo
👾 fixed remnant css var / fixed breadcrumb alignment
ee8523e
@mgiraldo
👾 version bump
c716a09
@mgiraldo
👾 added yarn step to analyzer
36cbe4e
@mgiraldo
Copy link
Contributor Author

i also added a dedicated printable version of the teaching guide:

  • when the user prints the page from the browser (⌘+P) the system now behaves as expected: it will print the current view
  • if the user clicks the “print this guide” link, a new tab is opened with a new page showing only the teaching guide and prompting the browser print() function

the way it was before was very hacky and the hack was not working with the new css... so i did this new process and removed the hack... because hacks are bad

@mgiraldo mgiraldo merged commit cdf0133 into master Apr 17, 2018
@mgiraldo mgiraldo deleted the next5 branch April 17, 2018 14:43
@mgiraldo mgiraldo removed the review label Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AudreyAltman AudreyAltman AudreyAltman approved these changes

@mdellabitta mdellabitta Awaiting requested review from mdellabitta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgiraldo @AudreyAltman