hang at boot due to cryptsetup error when using module 90crypt with rd.luks.key (regression) #1528
Labels
bug
Our bugs
Comments
lapseofreason
changed the title
lapseofreason
added a commit
to lapseofreason/dracut
that referenced
this issue
Jun 8, 2021
This was referenced Jun 8, 2021
lapseofreason
added a commit
to lapseofreason/dracut
that referenced
this issue
Jun 8, 2021
johannbg
pushed a commit
that referenced
this issue
Jun 8, 2021
aafeijoo-suse
pushed a commit
to aafeijoo-suse/dracut
that referenced
this issue
Sep 30, 2021
Fixes dracutdevs#1528. (cherry picked from commit e0abf88)
aafeijoo-suse
added a commit
to aafeijoo-suse/dracut
that referenced
this issue
Mar 9, 2022
dracut-056
Bug Fixes
---------
* **base:**
* do not change the provided UUID ([4e85874](dracutdevs@4e85874))
* add default device choice ([e8c18c9](dracutdevs@e8c18c9))
* tr needs to be installed ([dfbfd33](dracutdevs@dfbfd33))
* do not quote $initargs for switch_root ([f649cd1](dracutdevs@f649cd1))
* repair installing dracut-util ([d7acf10](dracutdevs@d7acf10))
* **bluetooth:**
* make hostonly configuration files optional ([d03fb67](dracutdevs@d03fb67))
* dbus configuration path fixes ([34b1dd2](dracutdevs@34b1dd2))
* **cms:** reload NetworkManager connections ([07977ee](dracutdevs@07977ee))
* **cpio:**
* correct dev_t -> rmajor/rminor mapping ([acc629a](dracutdevs@acc629a))
* write zeros instead of seek for padding and alignment ([0af11c5](dracutdevs@0af11c5))
* **crypt:** remove quotes from cryptsetupopts ([e0abf88](dracutdevs@e0abf88), closes [dracutdevs#1528](dracutdevs#1528))
* **crypt-gpg:**
* tr needs to be installed ([a93fbc4](dracutdevs@a93fbc4))
* execute --card-status on each try ([6610093](dracutdevs@6610093))
* **dasd_rules:**
* correct udev dasd rules parsing ([5de6e4d](dracutdevs@5de6e4d))
* remove collect based udev rule creators ([ebafbd8](dracutdevs@ebafbd8))
* **dmsquash-live:**
* option to use overlayfs on a block device root ([813577e](dracutdevs@813577e))
* do not install systemd files when systemd is not enabled ([bf8738d](dracutdevs@bf8738d))
* iso-scan requires rmdir ([e19e389](dracutdevs@e19e389))
* correct regression introduced with shellcheck changes ([0c631ef](dracutdevs@0c631ef))
* **dmsquash-live-ntfs:** fuse3 no longer requires ulockmgr_server ([75ad269](dracutdevs@75ad269))
* **dracut:** be more robust when using 'set -u' ([22a8062](dracutdevs@22a8062))
* **dracut-functions.sh:**
* ip route parsing ([d754e1c](dracutdevs@d754e1c))
* get block device driver if in a virtual subsystem ([dc3b976](dracutdevs@dc3b976))
* **dracut-init:** unbreak a comment ([bc4f196](dracutdevs@bc4f196))
* **dracut-initramfs-restore.sh:**
* add missing compression options ([e86397d](dracutdevs@e86397d))
* add missing default paths ([3d8e1ad](dracutdevs@3d8e1ad), closes [dracutdevs#1628](dracutdevs#1628))
* **dracut-install:** tweaks to get_real_file() ([1beeaf3](dracutdevs@1beeaf3))
* **dracut-shutdown:** add cleanup handler on failure ([7ab1d00](dracutdevs@7ab1d00))
* **dracut-systemd:** do not use Requires for vconsole-setup.service ([a7f5429](dracutdevs@a7f5429))
* **dracut.sh:**
* do not ignore invalid config file or dir path ([7de9ffc](dracutdevs@7de9ffc))
* check kernel zstd support early ([475497b](dracutdevs@475497b))
* check availability of configured compression ([bdac657](dracutdevs@bdac657))
* inform user about auto-selected compression method ([06d47de](dracutdevs@06d47de))
* drop pointless check for module compression method ([586d3e7](dracutdevs@586d3e7))
* change misspelled variable name ([acfd97a](dracutdevs@acfd97a))
* remove wrong $ in loop sequence ([f1245b5](dracutdevs@f1245b5))
* handle symlinks appropriately while using '-i' option ([c7fbc0c](dracutdevs@c7fbc0c))
* handle '-i' option to include files beginning with '.' ([f113801](dracutdevs@f113801))
* **drm:** add privacy screen modules to the initrd ([14d97a6](dracutdevs@14d97a6))
* **fedora.conf.example:** rename misspelled variable ([9371dca](dracutdevs@9371dca))
* **fido2:** add a missing library ([4753738](dracutdevs@4753738))
* **fips:**
* missing sourcing of dracut-lib ([857b17f](dracutdevs@857b17f))
* add and remove local variables ([e8121bf](dracutdevs@e8121bf))
* wrong error message ([7f10c48](dracutdevs@7f10c48))
* handle s390x OSTree systems ([78557f0](dracutdevs@78557f0))
* **fips.sh:** repsect rd.fips.skipkernel ([5789abc](dracutdevs@5789abc))
* **img-lib:** install rmdir ([51ce889](dracutdevs@51ce889))
* **install:**
* segfault on popen error ([5c2f72f](dracutdevs@5c2f72f))
* extend hwcaps library handling to libraries under glibc-hwcaps/ ([10ed204](dracutdevs@10ed204))
* use size_t to avoid -Wsign-compare warning ([55468a2](dracutdevs@55468a2))
* improve gettid definition ([ef0f848](dracutdevs@ef0f848))
* validate return values log.c ([19537f8](dracutdevs@19537f8))
* rectify unused function args in log.c ([b5cf7ec](dracutdevs@b5cf7ec))
* use wrapper for asprintf ([e2a6159](dracutdevs@e2a6159))
* use unsigned int instead of unsigned ([74a4179](dracutdevs@74a4179))
* reduce cppcheck warnings ([b0bf818](dracutdevs@b0bf818))
* add a missing ret value assignment ([6a44426](dracutdevs@6a44426))
* **integrity:** add support for loading multiple EVM x509 certs ([9da76af](dracutdevs@9da76af))
* **iscsi:** add support for the new iscsiadm "no-wait" (-W) command ([7374943](dracutdevs@7374943))
* **kernel-modules:**
* add mailbox drivers for arm ([0e80ff7](dracutdevs@0e80ff7))
* detect block device's hardware driver ([c86f4d2](dracutdevs@c86f4d2))
* add blk_mq_alloc_disk and blk_cleanup_disk to blockfuncs ([b292ce7](dracutdevs@b292ce7))
* add more modules on RISC-V ([3cc9f1c](dracutdevs@3cc9f1c))
* add isp1760 USB controller ([1539845](dracutdevs@1539845))
* add Type-C USB drivers for generic initrd ([a1287c6](dracutdevs@a1287c6))
* **kernel-modules-extra:** handle zstd module extension ([b3d2dcb](dracutdevs@b3d2dcb))
* **lvm:**
* restore setting LVM_MD_PV_ACTIVATED ([164e5eb](dracutdevs@164e5eb))
* replace --partial option ([97543cc](dracutdevs@97543cc))
* **man:** default value of rd.retry was increased to 180 seconds ([4855242](dracutdevs@4855242))
* **mdraid:** allow UUID comparison for more than one UUID ([d364ce8](dracutdevs@d364ce8))
* **memstrack:** drop bash runtime requirement ([35822f3](dracutdevs@35822f3))
* **mksh:** requires printf ([f806a62](dracutdevs@f806a62))
* **multipath:**
* check if mpathconf is available ([4318533](dracutdevs@4318533))
* drop ExecStop= setting from service unit ([9491e59](dracutdevs@9491e59))
* get config. dir from configuration ([2e3c544](dracutdevs@2e3c544))
* **multipathd.service:**
* drop dependencies on iscsi and iscsid ([6246da4](dracutdevs@6246da4))
* adapt to upstream multipath-tools unit file ([a247d2b](dracutdevs@a247d2b))
* remove dependency on systemd-udev-settle ([371b338](dracutdevs@371b338))
* **network:**
* consistent use of "$gw" for gateway ([3f2c76b](dracutdevs@3f2c76b))
* wrong test of wicked unit ([22e6830](dracutdevs@22e6830))
* add errors and warnings when network interface does not exist ([7938935](dracutdevs@7938935))
* **network-manager:**
* skip non-directories in /sys/class/net ([d9c3c77](dracutdevs@d9c3c77))
* disable tty output if the console is not usable ([f6e6be2](dracutdevs@f6e6be2))
* show output on console only with rd.debug enabled ([e07b7ad](dracutdevs@e07b7ad))
* write DHCP filename option to dhcpopts file ([38320fc](dracutdevs@38320fc))
* check for nm-initrd-generator in both /usr/{libexec,lib} ([5ee7e24](dracutdevs@5ee7e24))
* ensure safe content of /tmp/dhclient."$ifname".dhcpopts ([e509c63](dracutdevs@e509c63))
* include nm-daemon-helper binary ([0e59053](dracutdevs@0e59053))
* don't pull in systemd-udev-settle ([a0f12fb](dracutdevs@a0f12fb))
* support teaming under NM+systemd ([a97d2ce](dracutdevs@a97d2ce))
* pull in network.target in nm-initrd.service ([a97d6e2](dracutdevs@a97d6e2))
* **network-wicked:** multiple path corrections ([d3b5bc1](dracutdevs@d3b5bc1))
* **nvmf:** validate_ip_conn ([655c65e](dracutdevs@655c65e))
* **qeth_rules:** check the existence of /sys/devices/qeth/*/online beforehand ([6c71ba4](dracutdevs@6c71ba4))
* **resume:**
* resume using /usr/lib64/suspend ([c459373](dracutdevs@c459373))
* check for presence of /sys/power/resume ([0b97790](dracutdevs@0b97790))
* **rootfs-block:** make the base module dependency explicit ([3326e4c](dracutdevs@3326e4c))
* **s390_rules:** drop collect installation ([f905c3a](dracutdevs@f905c3a))
* **shutdown:** be robust against forced shutdown ([b9ba3c8](dracutdevs@b9ba3c8))
* **skipcpio:**
* calculate and use CPIO_MAGIC_LEN ([3fb8723](dracutdevs@3fb8723))
* improve error checking ([f6d16b6](dracutdevs@f6d16b6))
* **squash:**
* apply FIPS and libpthread workaround ([5ab18de](dracutdevs@5ab18de))
* remove tailing '/' when installing ld.so.conf.d ([cbd8559](dracutdevs@cbd8559))
* keep ld cache under initdir ([dc21638](dracutdevs@dc21638))
* create relative symlinks ([a2b6be4](dracutdevs@a2b6be4))
* **systemd-sysusers:**
* use split systemd sysuser configs ([fec93bb](dracutdevs@fec93bb))
* override systemd-sysusers.service ([dcbe23c](dracutdevs@dcbe23c))
* **tpm2-tss:**
* add a missing library ([c656b61](dracutdevs@c656b61))
* typo in depends() ([8b17105](dracutdevs@8b17105))
* **url-lib:**
* SC2086: Double quote to prevent globbing and word splitting ([acb1886](dracutdevs@acb1886))
* SC2046: Quote this to prevent word splitting ([ec50cec](dracutdevs@ec50cec))
* improve ca-bundle detection ([e3bb181](dracutdevs@e3bb181))
* make pre-pivot hook separetely per nfs mount ([2f091b1](dracutdevs@2f091b1))
* **usrmount:** do not empty _dev variable ([4afdcba](dracutdevs@4afdcba))
* **zfcp_rules:**
* correct udev zfcp rules parsing ([5925266](dracutdevs@5925266))
* remove collect based udev rule creators ([d40c49a](dracutdevs@d40c49a))
Features
--------
* **Makefile:** cargo wrapper for dracut-cpio build ([51d21c6](dracutdevs@51d21c6))
* **cpio:**
* add newc archive creation utility ([a9c6704](dracutdevs@a9c6704))
* add rust argument parsing library from crosvm ([94fc502](dracutdevs@94fc502))
* **crypt:**
* check if pkcs11 module is needed in hostonly mode ([56f4fb6](dracutdevs@56f4fb6))
* check if fido2 module is needed in hostonly mode ([d5fd030](dracutdevs@d5fd030))
* check if tpm2-tss module is needed in hostonly mode ([5d990a0](dracutdevs@5d990a0))
* **dracut.sh:**
* add --aggresive-strip option ([67fc670](dracutdevs@67fc670))
* add "--enhanced-cpio" option for calling dracut-cpio ([afe4a6d](dracutdevs@afe4a6d))
* check if target kernel has zstd support compiled in ([591118c](dracutdevs@591118c))
* **fido2:** introducing the fido2 module ([049973b](dracutdevs@049973b))
* **lvm:**
* only run lvchange for LV that is seen on devices ([1af4674](dracutdevs@1af4674))
* use generated filter when none is set ([7ffc5e3](dracutdevs@7ffc5e3))
* update lvm command options ([c0a54f2](dracutdevs@c0a54f2))
* **pcsc:** introducing the pcsc module ([dcaff88](dracutdevs@dcaff88))
* **pkcs11:**
* include the module in the spec file ([c5907f8](dracutdevs@c5907f8))
* introducing the pkcs11 module ([83ea8cf](dracutdevs@83ea8cf))
* **spec:** add systemd-integritysetup module ([fe8df02](dracutdevs@fe8df02))
* **squash:** install umount util ([563f543](dracutdevs@563f543))
* **systemd:** enable support for systemd compiled with ASAN ([d502d2a](dracutdevs@d502d2a))
* **systemd-integritysetup:** introducing the systemd-integritysetup module ([33cf47a](dracutdevs@33cf47a))
Contributors
------------
- Antonio Alvarez Feijoo <antonio.feijoo@suse.com>
- David Disseldorp <ddiss@suse.de>
- Martin Wilck <mwilck@suse.de>
- Jóhann B. Guðmundsson <johannbg@gmail.com>
- Shreenidhi Shedi <sshedi@vmware.com>
- David Teigland <teigland@redhat.com>
- Beniamino Galvani <bgalvani@redhat.com>
- Thomas Blume <thomas.blume@suse.com>
- Kairui Song <kasong@redhat.com>
- Laszlo Gombos <laszlo.gombos@gmail.com>
- Renaud Métrich <rmetrich@redhat.com>
- Dusty Mabe <dusty@dustymabe.com>
- Masahiro Matsuya <mmatsuya@redhat.com>
- Alexander Wenzel <alexander.wenzel@qbeyond.de>
- Andre Russ <andre.russ@sap.com>
- Cornelius Hoffmann <coding@hoffmn.de>
- David Tardon <dtardon@redhat.com>
- Frantisek Sumsal <frantisek@sumsal.cz>
- Harald Hoyer <harald@profian.com>
- José María Fernández <josemariafg@gmail.com>
- Kairui Song <kasong@tencent.com>
- Peter Robinson <pbrobinson@fedoraproject.org>
- Pingfan Liu <piliu@redhat.com>
- Tony Asleson <tasleson@redhat.com>
- Zoltán Böszörményi <zboszor@gmail.com>
- Adrien Thierry <athierry@redhat.com>
- Alexander Tsoy <alexander@tsoy.me>
- Andreas Schwab <schwab@suse.de>
- Andrey Sokolov <keremet@altlinux.org>
- Brandon Sloane <btsloane@verizon.net>
- Charles Rose <charles.rose@dell.com>
- Coiby Xu <coxu@redhat.com>
- Dan Horák <dhorak@redhat.com>
- Dirk Müller <dirk@dmllr.de>
- Glenn Morris <rgm@stanford.edu>
- Hans de Goede <hdegoede@redhat.com>
- Hari Bathini <hbathini@linux.ibm.com>
- Henrik Gombos <henrik99999@gmail.com>
- Jonathan Lebon <jonathan@jlebon.com>
- LinkTed <link.ted@mailbox.org>
- Lubomir Rintel <lkundrak@v3.sk>
- Luca BRUNO <luca.bruno@coreos.com>
- Lukas Nykryn <lnykryn@redhat.com>
- Matthias Berndt <matthias_berndt@gmx.de>
- Mike Gilbert <floppym@gentoo.org>
- Pavel Valena <pvalena@redhat.com>
- Stefan Berger <stefanb@linux.ibm.com>
- Thomas Haller <thaller@redhat.com>
- Tomasz Paweł Gajc <tpgxyz@gmail.com>
- Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
- joshuacov1 <joshuacov@gmail.com>
- lapseofreason <lapseofreason0@gmail.com>
aafeijoo-suse
pushed a commit
to aafeijoo-suse/dracut
that referenced
this issue
Mar 31, 2022
Fixes dracutdevs#1528. (cherry picked from commit e0abf88)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
cryptsetup error when using module 90crypt with rd.luks.key due to incorrectly quoted command, leading to hang at boot. It displays a password prompt, but does not accept the correct password for the key file.
The bug is triggered if
$cryptsetupoptsindracut/modules.d/90crypt/cryptroot-ask.shcontains multiple options separated by spaces, which happens for example if allow discards is specified. The two offending lines are:and
In both
"$cryptsetupopts"should be changed to$cryptsetupopts(without quotation marks).Distribution used
Fedora 34
Dracut version
dracut 054-6.git20210518.fc34
Init system
systemd omitted from dracutmodules
To Reproduce
See downstream bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1963424 (only original bug report and not comments, as they seem to be off-topic).
Expected behavior
The root partition should be unlocked automatically.
Additional context
The bug was first introduced in version 054 commit 682b297.
The text was updated successfully, but these errors were encountered: