Remove quotes from cryptsetupopts in 90crypt module #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crypt
haraldh
approved these changes
Jun 8, 2021
johannbg
requested changes
Jun 8, 2021
There was a problem hiding this comment.
Your pr is failing both the commisery test and the shell linter test
To fix the commisery check change your commit msg
from
Remove quotes from cryptsetupopts in 90crypt module
to
fix(crypt): remove quotes from cryptsetupopts
You will need to disable the failing linter shell check ( Double quote to prevent globbing and word splitting) which get triggered when you remove the quotes for your change.
You can do so by adding the following line to the if/readkey statements
# shellcheck disable=SC2086
auto-merge was automatically disabled
June 8, 2021 18:55
Head branch was pushed to by a user without write access
lapseofreason
force-pushed
the
fix-cryptsetupopts-90crypt
branch
from
cab7737 to
19a0f22
Compare
|
@johannbg Thanks for the pointers, I made the changes. |
johannbg
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression that prevents unlocking of a luks volume with a key file using the 90crypt module.
The reason for the regression is the incorrectly quoted variable $cryptsetupoptions that can contain multiple arguments separated by spaces.
Changes
Fixes #1528