tests: remove useless test files #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desiki-high
requested review from
bergwolf,
ccx1024cc and
changweige
and removed request for
a team
Desiki-high
force-pushed
the
remove-nydusify-tests
branch
from
3d94d18
to
5507998
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1520 +/- ##
==========================================
- Coverage 62.73% 62.73% -0.01%
==========================================
Files 129 129
Lines 44158 44158
Branches 44158 44158
==========================================
- Hits 27703 27702 -1
Misses 15088 15088
- Partials 1367 1368 +1 |
Since dragonflyoss#983, we have the new smoke test, we can remove the old smoke test files including nydusify and nydus. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high
force-pushed
the
remove-nydusify-tests
branch
from
5507998
to
6b28ea2
Compare
|
@Desiki-high @imeoer I'm not very confident about this PR. Are we sure all nydusify tests have been migrated to smoke tests? |
|
Most of the tests are covered by smoke, and I will add the tests to |
|
@adamqqqplay If you find that certain tests are not be covered, feel free to point them out for me. Thanks. |
|
@Desiki-high Thanks for the explanation, I'll let you know if I find any problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
N/A
Details
Since #983, we have the new smoke test, we can remove the old smoke test files of nydusify and nydus.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.