nydusify: add unit test #1526
Merged
nydusify: add unit test #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desiki-high
requested review from
imeoer,
adamqqqplay and
power-more
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1526 +/- ##
==========================================
+ Coverage 60.90% 61.35% +0.45%
==========================================
Files 141 145 +4
Lines 46277 46629 +352
Branches 44153 44153
==========================================
+ Hits 28183 28610 +427
+ Misses 16658 16565 -93
- Partials 1436 1454 +18
|
Desiki-high
changed the title
Desiki-high
force-pushed
the
nydusify/ut-cmd
branch
5 times, most recently
from
8c02d5a
to
d09d167
Compare
Desiki-high
requested review from
bergwolf and
changweige
and removed request for
a team
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high
force-pushed
the
nydusify/ut-cmd
branch
from
d51b0d8
to
af8ef5b
Compare
Desiki-high
force-pushed
the
nydusify/ut-cmd
branch
7 times, most recently
from
5aca773
to
33feb90
Compare
master branch is unstable, change to v3. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
use `make test` to run unit tests, it don't need build. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high
force-pushed
the
nydusify/ut-cmd
branch
from
33feb90
to
e7ecc55
Compare
Desiki-high
force-pushed
the
nydusify/ut-cmd
branch
from
e7ecc55
to
530d259
Compare
We had removed the tests files(e2e) in nydusify, we need add the unit tests to improve test coverage. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
Ref: #1520
Details
Add more unit tests for
nydusify.Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.