Fix database selection translation issue (#799)Fix database selection translation issue (#799)Fix database selection translation issue (#799) #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add translation keys for all database names (MySQL, PostgreSQL, SQLite, MariaDB, MSSQL, Oracle SQL) - Update Workspace.jsx to use i18n translation function for database names - Ensure database names are translatable across all 48 supported languages Fixes drawdb-io#799
|
@VISHNU7KASIREDDY is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@alexanderzeillinger @jonas-grgt @progh2 @FelixZY ,Please review this when you are free ,thank you. |
Contributor
|
Disclaimer: I'm not a maintainer, simply a contributor.
|
- Add translation keys for all database descriptions in en.js - Add Bengali translations for database names and descriptions in bn.js - Update databases.js to use i18n.t() for descriptions - Update Workspace.jsx to render translated descriptions for all databases - Revert unnecessary package-lock.json changes Fixes drawdb-io#799
Author
|
@FelixZY thanks for your suggestions ,i had corrected. |
Member
|
Thank you @FelixZY for jumping in❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #799 where database selection options were not translated when users switched languages.
Changes
en.js.Workspace.jsxto use the i18n translation function (t()) for database names and the generic description.db_transactsqlis used for MSSQL.Testing
Closes #799- Add translation keys for all database names (MySQL, PostgreSQL, SQLite, MariaDB, MSSQL, Oracle SQL)
Fixes #799### Summary
Fixes issue #799 where database selection options were not translated when users switched languages.
Changes
en.js.Workspace.jsxto use the i18n translation function (t()) for database names and the generic description.db_transactsqlis used for MSSQL.Testing
Closes #799