fix: bugs in format painter #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuhongz
commented
Dec 7, 2023
yuhongz
commented
- format painter set merges
- set cursor when format painter is enabled
- range mark conflicts between format-painter and clipboard
- delete useless merge mutation
- set copy range style
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #677 +/- ##
==========================================
- Coverage 41.07% 34.66% -6.42%
==========================================
Files 297 346 +49
Lines 18045 22060 +4015
Branches 3647 4392 +745
==========================================
+ Hits 7412 7646 +234
- Misses 9114 12385 +3271
- Partials 1519 2029 +510 ☔ View full report in Codecov by Sentry. |
View Deployment
View Storybook
|
wzhudev
requested changes
Dec 7, 2023
packages/sheets-ui/src/commands/commands/add-worksheet-merge.command.ts
Outdated
Show resolved
Hide resolved
yuhongz
force-pushed
the
yuhongz/bugfixs-3
branch
from
b02e6d9
to
c22a2a4
Compare
|
SonarCloud Quality Gate failed.
|
wzhudev
approved these changes
Dec 9, 2023
lumixraku
added a commit
that referenced
this pull request
May 25, 2024
* fix(sheet): render viewport wrong size * fix: new viewport need more param * feat: cache by viewport * fix: markdirty & scrolling was conflict before, so scrolling & dirty did not refresh whole viewport * fix: 0510-1725 fix: #676 #677 fix: browser native zoom * fix: blurry when applyCache especially in windows 175% * fix: merge cells background fix: #676 test: #677 fix: #700 fix: aux line background fix: spreadsheet fix: precise rect for background * feat: fix cf render error on printing mode fix: #700 * fix: viewport make dirty false chore: eslint fix * test(facade): fix canvas mock fix: new viewport need more param222 test: mock canvas fix: rm useless * fix: should beginPath before clip() * chore: comments to english fix: expand shouldupdatecache chore: better code * fix: change viewport update timing fix: update visible cache viewport area --------- Co-authored-by: DR-Univer <wbfsa@qq.com> Co-authored-by: zw <zhang9748@foxmail.com> Co-authored-by: 白熱 <sonne@asaki.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.