Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): formula show and add selection move #676

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Dec 7, 2023

  1. 为seletionManagerService增加了moveStart, moving, moveEnd的subject
  2. sid的函数可以在formula bar看到,能够在editor编辑
  3. 数组公式高亮,以及可以在formula bar查看。
  4. 数据公式非primary的单元格,公式置灰
  5. 新增ICellDataForSheetInceptor
  6. 解决双击编辑单元格不灵活问题

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (f6a2fe9) 48.42% compared to head (0269d0c) 41.22%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...es/engine-formula/src/models/formula-data.model.ts 65.38% 15 Missing and 3 partials ⚠️
...s/engine-formula/src/functions/math/sumif/sumif.ts 0.00% 10 Missing and 3 partials ⚠️
...s/sheets/src/services/selection-manager.service.ts 67.64% 11 Missing ⚠️
...src/services/selection/selection-render.service.ts 33.33% 7 Missing and 1 partial ⚠️
packages/sheets/src/basics/selection.ts 0.00% 2 Missing ⚠️
packages/core/src/shared/array-search.ts 0.00% 0 Missing and 1 partial ⚠️
packages/core/src/sheets/styles.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #676      +/-   ##
==========================================
- Coverage   48.42%   41.22%   -7.21%     
==========================================
  Files         214      296      +82     
  Lines       14434    17999    +3565     
  Branches     2946     3642     +696     
==========================================
+ Hits         6990     7420     +430     
- Misses       6375     9069    +2694     
- Partials     1069     1510     +441     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 7, 2023

View Deployment

📝 Doc 📊 Sheet 📽️ Slide
🔗 Preview link 🔗 Preview link 🔗 Preview link

View Storybook

📚 Storybook
🔗 Preview link

@Dushusir
Copy link
Member

Dushusir commented Dec 7, 2023

getFormulaItemBySId这里,后面我看下是不是可以保证初始化时就存储好,免去查找

@DR-Univer DR-Univer requested a review from Jocs as a code owner December 8, 2023 10:14
@DR-Univer DR-Univer force-pushed the feat-array-formula-hightlight branch from 04da06e to 2a34114 Compare December 8, 2023 10:18
Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@DR-Univer DR-Univer merged commit d5be1cb into dev Dec 8, 2023
11 checks passed
@DR-Univer DR-Univer deleted the feat-array-formula-hightlight branch December 8, 2023 11:29
lumixraku added a commit that referenced this pull request May 10, 2024
lumixraku added a commit that referenced this pull request May 11, 2024
lumixraku added a commit that referenced this pull request May 11, 2024
lumixraku added a commit that referenced this pull request May 13, 2024
lumixraku added a commit that referenced this pull request May 13, 2024
lumixraku added a commit that referenced this pull request May 14, 2024
lumixraku added a commit that referenced this pull request May 14, 2024
lumixraku added a commit that referenced this pull request May 14, 2024
lumixraku added a commit that referenced this pull request May 14, 2024
lumixraku added a commit that referenced this pull request May 14, 2024
lumixraku added a commit that referenced this pull request May 15, 2024
lumixraku added a commit that referenced this pull request May 15, 2024
jikkai pushed a commit that referenced this pull request May 15, 2024
jikkai pushed a commit that referenced this pull request May 15, 2024
lumixraku added a commit that referenced this pull request May 15, 2024
lumixraku added a commit that referenced this pull request May 15, 2024
lumixraku added a commit that referenced this pull request May 15, 2024
lumixraku added a commit that referenced this pull request May 15, 2024
lumixraku added a commit that referenced this pull request May 16, 2024
lumixraku added a commit that referenced this pull request May 16, 2024
lumixraku added a commit that referenced this pull request May 16, 2024
lumixraku added a commit that referenced this pull request May 16, 2024
lumixraku added a commit that referenced this pull request May 16, 2024
lumixraku added a commit that referenced this pull request May 16, 2024
lumixraku added a commit that referenced this pull request May 20, 2024
fix: #676 #677

fix: browser native zoom
lumixraku added a commit that referenced this pull request May 20, 2024
fix: #676

test: #677

fix: #700

fix: aux line background

fix: spreadsheet

fix: precise rect for background
lumixraku added a commit that referenced this pull request May 21, 2024
fix: #676 #677

fix: browser native zoom
lumixraku added a commit that referenced this pull request May 21, 2024
fix: #676

test: #677

fix: #700

fix: aux line background

fix: spreadsheet

fix: precise rect for background
lumixraku added a commit that referenced this pull request May 22, 2024
fix: #676 #677

fix: browser native zoom
lumixraku added a commit that referenced this pull request May 22, 2024
fix: #676

test: #677

fix: #700

fix: aux line background

fix: spreadsheet

fix: precise rect for background
lumixraku added a commit that referenced this pull request May 23, 2024
fix: #676 #677

fix: browser native zoom
lumixraku added a commit that referenced this pull request May 23, 2024
fix: #676

test: #677

fix: #700

fix: aux line background

fix: spreadsheet

fix: precise rect for background
lumixraku added a commit that referenced this pull request May 24, 2024
fix: #676 #677

fix: browser native zoom
lumixraku added a commit that referenced this pull request May 24, 2024
fix: #676

test: #677

fix: #700

fix: aux line background

fix: spreadsheet

fix: precise rect for background
lumixraku added a commit that referenced this pull request May 24, 2024
fix: #676 #677

fix: browser native zoom
lumixraku added a commit that referenced this pull request May 24, 2024
fix: #676

test: #677

fix: #700

fix: aux line background

fix: spreadsheet

fix: precise rect for background
lumixraku added a commit that referenced this pull request May 25, 2024
* fix(sheet): render viewport wrong size

* fix: new viewport need more param

* feat: cache by viewport

* fix: markdirty & scrolling was conflict before, so scrolling & dirty did not refresh whole viewport

* fix: 0510-1725

fix: #676 #677

fix: browser native zoom

* fix: blurry when applyCache especially in windows 175%

* fix: merge cells background

fix: #676

test: #677

fix: #700

fix: aux line background

fix: spreadsheet

fix: precise rect for background

* feat: fix cf render error on printing mode

fix: #700

* fix: viewport make dirty false

chore: eslint fix

* test(facade): fix canvas mock

fix: new viewport need more param222

test: mock canvas

fix: rm useless

* fix: should beginPath before clip()

* chore: comments to english

fix: expand shouldupdatecache

chore: better code

* fix: change viewport update timing

fix: update visible cache viewport area

---------

Co-authored-by: DR-Univer <wbfsa@qq.com>
Co-authored-by: zw <zhang9748@foxmail.com>
Co-authored-by: 白熱 <sonne@asaki.me>
lumixraku added a commit that referenced this pull request May 27, 2024
fix: #676 #677

fix: browser native zoom
lumixraku added a commit that referenced this pull request May 27, 2024
fix: #676

test: #677

fix: #700

fix: aux line background

fix: spreadsheet

fix: precise rect for background
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants