-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sheet): formula show and add selection move #676
Conversation
DR-Univer
commented
Dec 7, 2023
•
edited
Loading
edited
- 为seletionManagerService增加了moveStart, moving, moveEnd的subject
- sid的函数可以在formula bar看到,能够在editor编辑
- 数组公式高亮,以及可以在formula bar查看。
- 数据公式非primary的单元格,公式置灰
- 新增ICellDataForSheetInceptor
- 解决双击编辑单元格不灵活问题
c20c98c
to
f384a1e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #676 +/- ##
==========================================
- Coverage 48.42% 41.22% -7.21%
==========================================
Files 214 296 +82
Lines 14434 17999 +3565
Branches 2946 3642 +696
==========================================
+ Hits 6990 7420 +430
- Misses 6375 9069 +2694
- Partials 1069 1510 +441 ☔ View full report in Codecov by Sentry. |
View Deployment
View Storybook
|
getFormulaItemBySId这里,后面我看下是不是可以保证初始化时就存储好,免去查找 |
04da06e
to
2a34114
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
* fix(sheet): render viewport wrong size * fix: new viewport need more param * feat: cache by viewport * fix: markdirty & scrolling was conflict before, so scrolling & dirty did not refresh whole viewport * fix: 0510-1725 fix: #676 #677 fix: browser native zoom * fix: blurry when applyCache especially in windows 175% * fix: merge cells background fix: #676 test: #677 fix: #700 fix: aux line background fix: spreadsheet fix: precise rect for background * feat: fix cf render error on printing mode fix: #700 * fix: viewport make dirty false chore: eslint fix * test(facade): fix canvas mock fix: new viewport need more param222 test: mock canvas fix: rm useless * fix: should beginPath before clip() * chore: comments to english fix: expand shouldupdatecache chore: better code * fix: change viewport update timing fix: update visible cache viewport area --------- Co-authored-by: DR-Univer <wbfsa@qq.com> Co-authored-by: zw <zhang9748@foxmail.com> Co-authored-by: 白熱 <sonne@asaki.me>