Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(render-engine): move cache to viewport #2188

Merged
merged 13 commits into from
May 25, 2024
Merged

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented May 8, 2024

A description of the proposed changes:
Moving the cache canvas from the spreadsheet to the viewport is primarily for the scenario of freezing rows and columns.

How to test them:

  • Performance: The FPS performance during scrolling should theoretically be consistent with the performance when there are no frozen rows or columns.

  • Font rendering: specially in scenarios involving overflow and merged cells spanning frozen rows and columns.

  • Correct texture mapping: such as avoiding blank textures and ensuring complete rendering of text and background colors.

BREAKING CHANGE:
Before:
cache canvas was controlled by spreadsheet.
After:
cache canvas was created by viewport

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 696 lines in your changes are missing coverage. Please review.

Project coverage is 30.02%. Comparing base (95d61bd) to head (d988566).

Files Patch % Lines
packages/engine-render/src/viewport.ts 0.00% 261 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 161 Missing ⚠️
...eets-ui/src/controllers/sheet-render.controller.ts 0.00% 54 Missing ⚠️
packages/engine-render/src/basics/tools.ts 0.00% 29 Missing ⚠️
packages/engine-render/src/layer.ts 0.00% 28 Missing ⚠️
packages/sheets-ui/src/views/sheet-canvas-view.ts 0.00% 20 Missing ⚠️
...ne-render/src/components/sheets/extensions/font.ts 0.00% 18 Missing ⚠️
...der/src/components/sheets/extensions/background.ts 0.00% 17 Missing ⚠️
...rc/components/sheets/extensions/sheet-extension.ts 0.00% 15 Missing ⚠️
.../engine-render/src/components/sheets/interfaces.ts 0.00% 10 Missing ⚠️
... and 30 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2188      +/-   ##
==========================================
- Coverage   30.17%   30.02%   -0.15%     
==========================================
  Files        1418     1418              
  Lines       72561    72922     +361     
  Branches    15201    15280      +79     
==========================================
  Hits        21892    21892              
- Misses      50669    51030     +361     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the fix-render-viewport-error.pr branch from c31b854 to 28af776 Compare May 8, 2024 08:18
@lumixraku lumixraku changed the title Fix render viewport error.pr feat(viewport): Fix sheet render viewport error May 8, 2024
@lumixraku lumixraku changed the title feat(viewport): Fix sheet render viewport error feat(render-engine): move cache to viewport May 8, 2024
Copy link

github-actions bot commented May 8, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku force-pushed the fix-render-viewport-error.pr branch 3 times, most recently from 10db720 to aef9846 Compare May 8, 2024 08:54
@DR-Univer DR-Univer added the qa:untested This PR is ready to be tested label May 9, 2024
@lumixraku lumixraku force-pushed the fix-render-viewport-error.pr branch 6 times, most recently from 196b018 to 4762414 Compare May 11, 2024 06:08
@lumixraku lumixraku requested a review from Gggpound as a code owner May 13, 2024 04:06
@lumixraku lumixraku force-pushed the fix-render-viewport-error.pr branch 6 times, most recently from a4138c4 to cf26fa1 Compare May 13, 2024 12:16
@lumixraku lumixraku force-pushed the fix-render-viewport-error.pr branch 2 times, most recently from f14a428 to 37e4950 Compare May 14, 2024 06:40
@lumixraku lumixraku force-pushed the fix-render-viewport-error.pr branch from c827f73 to 5d4d3b7 Compare May 22, 2024 11:41
packages/core/src/shared/tools.ts Outdated Show resolved Hide resolved
packages/engine-render/src/components/extension.ts Outdated Show resolved Hide resolved
packages/engine-render/src/layer.ts Outdated Show resolved Hide resolved
packages/engine-render/src/viewport.ts Outdated Show resolved Hide resolved
@lumixraku lumixraku force-pushed the fix-render-viewport-error.pr branch 10 times, most recently from f24d3a3 to 0b81b50 Compare May 24, 2024 09:55
@lumixraku lumixraku force-pushed the fix-render-viewport-error.pr branch from 0b81b50 to 613e3dd Compare May 24, 2024 09:58
fix: update visible cache viewport area
@lumixraku lumixraku force-pushed the fix-render-viewport-error.pr branch from 613e3dd to d988566 Compare May 24, 2024 10:01
@lumixraku lumixraku merged commit a4e5b11 into dev May 25, 2024
9 checks passed
@lumixraku lumixraku deleted the fix-render-viewport-error.pr branch May 25, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants