fix(sheet): restore code in setStyleCommand #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
|
Please add a unit test. |
The test has been added. Please review again. @wzhudev |
wzhudev
requested changes
May 14, 2024
packages/sheets/src/commands/commands/__tests__/set-style.command.spec.ts
Outdated
Show resolved
Hide resolved
packages/sheets/src/commands/commands/__tests__/set-style.command.spec.ts
Outdated
Show resolved
Hide resolved
packages/sheets/src/commands/commands/__tests__/set-style.command.spec.ts
Outdated
Show resolved
Hide resolved
packages/sheets/src/commands/commands/__tests__/set-style.command.spec.ts
Outdated
Show resolved
Hide resolved
wzhudev
reviewed
May 16, 2024
| @@ -81,6 +82,52 @@ describe("Test commands used for updating cells' styles", () => { | |||
|
|
|||
| afterEach(() => univer.dispose()); | |||
|
|
|||
| describe('set style', () => { | |||
There was a problem hiding this comment.
No need to wrap the case in a describe.
wzhudev
approved these changes
May 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2225 +/- ##
=======================================
Coverage 30.83% 30.84%
=======================================
Files 1377 1377
Lines 70710 70710
Branches 14873 14873
=======================================
+ Hits 21804 21807 +3
+ Misses 48906 48903 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrectly change the original code. to fix it. Close #685