Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formula): add some math function #2761

Merged
merged 14 commits into from
Jul 19, 2024
Merged

feat(formula): add some math function #2761

merged 14 commits into from
Jul 19, 2024

Conversation

wpxp123456
Copy link
Contributor

close #1809

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 86.72397% with 139 lines in your changes missing coverage. Please review.

Project coverage is 26.71%. Comparing base (cede9f4) to head (42faa07).
Report is 2 commits behind head on dev.

Files Patch % Lines
...gine-formula/src/functions/math/randarray/index.ts 75.40% 30 Missing ⚠️
...ne-formula/src/functions/math/randbetween/index.ts 64.10% 14 Missing ⚠️
.../engine-formula/src/functions/math/mround/index.ts 68.29% 13 Missing ⚠️
...ngine-formula/src/functions/math/sumx2my2/index.ts 82.08% 12 Missing ⚠️
...ngine-formula/src/functions/math/sumx2py2/index.ts 82.08% 12 Missing ⚠️
...engine-formula/src/functions/math/sumxmy2/index.ts 82.08% 12 Missing ⚠️
...e-formula/src/functions/math/ceiling-math/index.ts 87.50% 6 Missing ⚠️
...engine-formula/src/functions/math/decimal/index.ts 90.38% 5 Missing ⚠️
...ine-formula/src/functions/math/floor-math/index.ts 90.90% 4 Missing ⚠️
...engine-formula/src/functions/math/degrees/index.ts 88.00% 3 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2761      +/-   ##
==========================================
+ Coverage   26.05%   26.71%   +0.66%     
==========================================
  Files        1741     1772      +31     
  Lines       92525    93515     +990     
  Branches    19566    19923     +357     
==========================================
+ Hits        24106    24982     +876     
- Misses      68419    68533     +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Jul 13, 2024
@oumomomo
Copy link

EXP函数
输入=EXP(E21:E23),删除引用列未报错
image

@univer-bot
Copy link

univer-bot bot commented Jul 17, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

EXP function
Enter =EXP(E21:E23), and no error is reported when deleting the reference column.
image

@wpxp123456 wpxp123456 force-pushed the feat/add-math-func branch 2 times, most recently from 765fc4b to 213ac6b Compare July 18, 2024 08:44
@dream-num dream-num deleted a comment from univer-bot bot Jul 18, 2024
@oumomomo
Copy link

DECIMAL函数
单元格内输入=DECIMAL("ceshi",15)可以计算出值,excel会报错
image

@univer-bot
Copy link

univer-bot bot commented Jul 18, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

DECIMAL function
Enter =DECIMAL("ceshi",15) in the cell to calculate the value, but Excel will report an error.
image

@oumomomo
Copy link

SECH函数
单元格内输入=SECH(2412414124),计算结果 错误
image

@univer-bot
Copy link

univer-bot bot commented Jul 19, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

SECH function
Enter =SECH(2412414124) in the cell, and the calculation result is incorrect.
image

@wpxp123456 wpxp123456 force-pushed the feat/add-math-func branch from 76510bd to d78d2bc Compare July 19, 2024 07:59
@dream-num dream-num deleted a comment from univer-bot bot Jul 19, 2024
@dream-num dream-num deleted a comment from univer-bot bot Jul 19, 2024
@dream-num dream-num deleted a comment from univer-bot bot Jul 19, 2024
@oumomomo oumomomo closed this Jul 19, 2024
@oumomomo oumomomo reopened this Jul 19, 2024
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jul 19, 2024
@wpxp123456 wpxp123456 merged commit 344f4dd into dev Jul 19, 2024
9 checks passed
@wpxp123456 wpxp123456 deleted the feat/add-math-func branch July 19, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Math Formulas
3 participants