Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a splash screen animation (Issue 53) #55

Merged
merged 2 commits into from
Mar 22, 2020
Merged

Add a splash screen animation (Issue 53) #55

merged 2 commits into from
Mar 22, 2020

Conversation

jama5262
Copy link
Contributor

What is the Purpose?

Adds an animated splash screen

What was the approach?

Created a SplashScreenActivity and animates using AndroidAnimation library and later opens the HomeActivity screen after the animation ends

Are there any concerns to addressed further before or after merging this PR?

  1. Did not create a feature for the splash screen, because the bottom nav was always there in the home screen, hence create an activity SplashScreenActivity in the app module

Mentions?

@wangerekaharun @chepsi @michaelbukachi

Issue(s) affected?

#53

@jama5262 jama5262 changed the title Add a splash screen animation Add a splash screen animation (Issue 53) Mar 22, 2020
@michaelbukachi
Copy link
Contributor

Hello @jama5262. Thanks for the PR. Your animation library is spot on! One thing we have to consider is that we don't want the animation to show every time. Imagine a situation where you are late for the conference. You just arrived. You really need to see active sessions so that you can hope into one of them. An animation wouldn't be a good idea in this scenario since you'd want the app to load as fast as possible. We will open another issue to handle this extra piece of logic.
I'll merge this as soon as any of the others check this out.
@chepsi @wangerekaharun @JabezNzomo99 check this out!

@jama5262
Copy link
Contributor Author

@michaelbukachi Thanks. I was also on the fence on actually adding the splash screen in terms of branding the app, but we could add a shared preference to show the splash screen for the first time opening the app.

@michaelbukachi
Copy link
Contributor

@jama5262 I've created #57 for the extra functionality. I'll merge this now.

@michaelbukachi michaelbukachi merged commit b41139c into droidconKE:develop Mar 22, 2020
@michaelbukachi
Copy link
Contributor

@jama5262 Instead of using an image you can make the animation play faster. Just a thought.

@jama5262 jama5262 deleted the issue-53 branch March 23, 2020 06:19
@wangerekaharun
Copy link
Contributor

Yes making animation play faster will also be good.

@wangerekaharun
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants