Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add watch/fetch for main props #429

Closed
8 of 9 tasks
Tracked by #427
, #529
...
Decipher opened this issue Feb 3, 2022 · 0 comments · Fixed by #430 or #536
Closed
8 of 9 tasks
Tracked by #427
, #529
...

Add watch/fetch for main props #429

Decipher opened this issue Feb 3, 2022 · 0 comments · Fixed by #430 or #536
Labels
enhancement New feature or request module: entity Related to the `druxt-entity` module module: site Related to the `druxt-site` module module: views Related to the `druxt-views` module
Milestone
1.0.0

Comments

@Decipher
Copy link
Member

Decipher commented Feb 3, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
As a Storybook user I want to see my DruxtBlock components update when I update the props.

Additionally, I want this to work consistently across all components.

Describe the solution you'd like

  • Add a watch/fetch for:
    • DruxtBlock: id & uuid
    • DruxtBlockRegion: name & theme
    • DruxtBreadcrumb: home & path
    • DruxtModule: langcode (via lang)
    • DruxtEntity: mode, settings, schemaType, type & uuid
    • DruxtMenu: To be refactored Refactor DruxtMenu #537
    • DruxtRouter: path
    • DruxtSite: theme
    • DruxtView: arguments, displayId, uuid, viewId

Describe alternatives you've considered
N/A

Additional context
N/A
@Decipher Decipher added enhancement New feature or request module: blocks Related to the `druxt-blocks` module labels Feb 3, 2022
Decipher added a commit that referenced this issue Feb 3, 2022
@Decipher
feat(#429): add id and uuid watch
d597857
@Decipher Decipher mentioned this issue Feb 3, 2022
Merged
7 tasks
Decipher added a commit that referenced this issue Feb 3, 2022
@Decipher
chore(#429): add test coverage
5fd6e11
Decipher added a commit that referenced this issue Feb 3, 2022
@Decipher
feat(#429): add id and uuid watch (#430)
1db9584 
* feat(#429): add id and uuid watch

* chore(#429): add test coverage
@Decipher Decipher mentioned this issue Feb 3, 2022
Closed
17 tasks
@Decipher Decipher changed the title [DruxtBlock] Add watch/fetch for ID and UUID prop Add watch/fetch for main props Feb 3, 2022
@Decipher Decipher reopened this Feb 3, 2022
Decipher added a commit that referenced this issue Feb 3, 2022
@Decipher
feat(#429): add watch fetch for DruxtBlockRegion
3ec59b9
Decipher added a commit that referenced this issue Feb 3, 2022
@Decipher
feat(#429): add watch fetch for DruxtBlockRegion (#432)
34d8397
@Decipher Decipher added module: breadcrumb Related to the `druxt-breadcrumb` module and removed module: breadcrumb Related to the `druxt-breadcrumb` module labels Feb 3, 2022
Decipher added a commit that referenced this issue Feb 3, 2022
@Decipher
feat(#429): add watch/fetch for DruxtBreadcrumb
af1c36e
Decipher added a commit that referenced this issue Feb 3, 2022
@Decipher
feat(#429): add watch/fetch for DruxtBreadcrumb (#435)
e2b8500
@Decipher Decipher mentioned this issue Feb 7, 2022
Merged
7 tasks
@Decipher Decipher added this to the 1.0.0 milestone Jun 14, 2022
@Decipher Decipher added module: entity Related to the `druxt-entity` module module: site Related to the `druxt-site` module module: views Related to the `druxt-views` module and removed module: blocks Related to the `druxt-blocks` module labels Jun 15, 2022
@Decipher Decipher mentioned this issue Jul 5, 2022
Closed
21 tasks
Decipher added a commit that referenced this issue Jul 15, 2022
@Decipher
feat(#429): update module prop watches
87d99d4
@Decipher Decipher mentioned this issue Jul 15, 2022
Merged
7 tasks
Decipher added a commit that referenced this issue Jul 18, 2022
@Decipher
chore(#429): added changesets
0483b77
Decipher added a commit that referenced this issue Jul 18, 2022
@Decipher
feat(#429): update module prop watches (#536)
2f2a7cc 
* feat(#429): update module prop watches

* chore(#429): added changesets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request module: entity Related to the `druxt-entity` module module: site Related to the `druxt-site` module module: views Related to the `druxt-views` module
Projects
None yet
Milestone
1.0.0
1 participant
@Decipher