Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#429): add watch fetch for DruxtBlockRegion #432

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

Decipher
Copy link
Member

@Decipher Decipher commented Feb 3, 2022

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Added watch/fetch for theme and name to DruxtBlockRegion

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Screenshots/Media:

@Decipher Decipher added enhancement New feature or request module: blocks Related to the `druxt-blocks` module labels Feb 3, 2022
@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2022

🦋 Changeset detected

Latest commit: 3ec59b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
druxt-blocks Minor
druxt-breadcrumb Patch
druxt-menu Patch
druxt-site Patch
druxt-views Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #432 (3ec59b9) into develop (1db9584) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #432   +/-   ##
========================================
  Coverage    96.87%   96.87%           
========================================
  Files           88       88           
  Lines         2912     2916    +4     
  Branches       639      639           
========================================
+ Hits          2821     2825    +4     
  Misses          83       83           
  Partials         8        8           
Impacted Files Coverage Δ
...ackages/blocks/src/components/DruxtBlockRegion.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1db9584...3ec59b9. Read the comment docs.

@Decipher Decipher merged commit 34d8397 into develop Feb 3, 2022
@Decipher Decipher deleted the feature/429-block_region_watch branch February 3, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module: blocks Related to the `druxt-blocks` module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant