Skip to content

Adds missing class doc string and __slots__ to _ReturnsAsserts, _PatchedContainer classes #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2020
Merged

Adds missing class doc string and __slots__ to _ReturnsAsserts, _PatchedContainer classes #417

merged 2 commits into from
Jun 11, 2020

Conversation

thepabloaguilar
Copy link
Member

@thepabloaguilar thepabloaguilar commented Jun 11, 2020 •
edited
Loading

Adds missing class doc string and __slots__ to _ReturnsAsserts, _PatchedContainer classes!
Adds missing @final decorator to the _PatchedContainer class!

closes #415
closes #416

@codecov
Copy link

codecov bot commented Jun 11, 2020 •
edited
Loading

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #417   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1192      1192           
  Branches       154       154           
=========================================
  Hits          1192      1192
Impacted Files Coverage Δ
returns/io.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9662e...6e60f0a. Read the comment docs.

@thepabloaguilar thepabloaguilar changed the title Adds missing class doc string and __slots__ to the _ReturnsAsserts class Adds missing class doc string and __slots__ to _ReturnsAsserts, _PatchedContainer classes Jun 11, 2020
sobolevn
sobolevn approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much thanks! ✋

@sobolevn sobolevn merged commit cf1018f into dry-python:master Jun 11, 2020
@thepabloaguilar thepabloaguilar deleted the feature/refs-415 branch June 20, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_PatchedContainer class should be final and should have slots _ReturnsAsserts class should have slots
2 participants
@thepabloaguilar @sobolevn