Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComputerManagementDsc: Add missing unit tests #406

Closed
wants to merge 4 commits into from

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 3, 2023

Pull Request (PR) description

The PR #402 will add unit tests for private function ConvertTo-Reason. The unit tests was converted from Pester 5 with as few changes as possible.

NOTE: This PR becomes obsolete if PR #405 is merged, merging that PR will close this PR.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #406 (08a09f6) into main (bf1ad27) will increase coverage by 0%.
The diff coverage is n/a.

❗ Current head 08a09f6 differs from pull request most recent head 5ee3eb4. Consider uploading reports for the commit 5ee3eb4 to get more accurate results

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #406   +/-   ##
===================================
  Coverage    89%    89%           
===================================
  Files        18     18           
  Lines      1940   1940           
===================================
+ Hits       1730   1731    +1     
+ Misses      210    209    -1     
Impacted Files Coverage Δ
source/ComputerManagementDsc.psm1 78% <0%> (+<1%) ⬆️

@PlagueHO PlagueHO reopened this Feb 25, 2023
@PlagueHO
Copy link
Member

Hi @johlju - this PR auto closed when I merged #405 - is this PR no longer required as the files that are bieng unit tested aren't here any more...

@johlju
Copy link
Member Author

johlju commented Feb 26, 2023

Correct. Sine the class-based resource now used the base class from the dependent module all these functions are no longer needed as they are part of the dependent module.

@johlju johlju closed this Feb 26, 2023
@johlju johlju deleted the fix/add-missing-tests branch February 26, 2023 08:07
@johlju johlju removed the needs review The pull request needs a code review. label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing unit tests for private functions
2 participants