Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComputerManagementDsc: Class-based resources re-use module DscResource.Base #405

Merged
merged 4 commits into from
Feb 25, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 3, 2023

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju changed the title ComputerManagementDsc: Class-based resources re-use module DscResourc… ComputerManagementDsc: Class-based resources re-use module DscResource.Base Jan 3, 2023
@johlju johlju added the needs review The pull request needs a code review. label Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #405 (9764d4d) into main (bf1ad27) will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #405    +/-   ##
====================================
+ Coverage    89%    90%    +1%     
====================================
  Files        18     18            
  Lines      1940   1802   -138     
====================================
- Hits       1730   1629   -101     
+ Misses      210    173    -37     
Impacted Files Coverage Δ
source/ComputerManagementDsc.psm1 85% <0%> (+7%) ⬆️

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 16 of 16 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@PlagueHO PlagueHO merged commit 41ec47e into dsccommunity:main Feb 25, 2023
@johlju johlju deleted the f/remove-resourcebase branch February 26, 2023 08:07
@johlju johlju removed the needs review The pull request needs a code review. label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants