Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComputerManagementDsc: Uses commands from DscResource.Common #408

Closed
wants to merge 1 commit into from

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 3, 2023

Pull Request (PR) description

  • ComputerManagementDsc
    • The private function Test-ResourceDscPropertyIsAssigned was removed as
      from now we should use Test-DscProperty -Name 'MyProperty' -HasValue, or
      Get-DscProperty -Name 'MyProperty' -HasValue depending what kind of
      return value is needed - Fixes Issue #407.
    • Now uses the commands Get-DscProperty and Test-DscProperty from
      the module DscResource.Common - Fixes Issue #407.
      • All uses of Get-DscProperty was changed to use the named parameter
        Attribute instead of the parameter alias Type.
      • All uses of Test-ResourceHasDscProperty was changed to use Test-DscProperty

NOTE: This PR becomes obsolete if PR #405 is merged, merging that PR will close this PR.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #408 (6c157b6) into main (41ec47e) will decrease coverage by 2%.
The diff coverage is n/a.

❗ Current head 6c157b6 differs from pull request most recent head 908e9e0. Consider uploading reports for the commit 908e9e0 to get more accurate results

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #408    +/-   ##
====================================
- Coverage    90%    89%    -2%     
====================================
  Files        18     18            
  Lines      1802   1910   +108     
====================================
+ Hits       1629   1700    +71     
- Misses      173    210    +37     
Impacted Files Coverage Δ
source/ComputerManagementDsc.psm1 73% <0%> (-12%) ⬇️

@PlagueHO PlagueHO reopened this Feb 25, 2023
@johlju
Copy link
Member Author

johlju commented Feb 26, 2023

This is no longer requiered as the functions was removed as part of PR #405.

@johlju johlju closed this Feb 26, 2023
@johlju johlju deleted the fix/use-dscresource.common branch February 26, 2023 08:20
@johlju johlju removed the needs review The pull request needs a code review. label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-use command Get-DscProperty and Test-DscProperty from DscResource.Base
2 participants