-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServerProtocolTcpIp: New resource proposal #1378
Labels
resource proposal
The issue is proposing a new resource in the resource module.
Comments
johlju
added
help wanted
The issue is up for grabs for anyone in the community.
resource proposal
The issue is proposing a new resource in the resource module.
labels
Jun 17, 2019
There might be some code that can be reused in the closed PR #1045. |
5 tasks
The are some code in #339 (comment) that can be used to get test data. Also this issue also closes issue #339. |
johlju
added
in progress
The issue is being actively worked on by someone.
and removed
help wanted
The issue is up for grabs for anyone in the community.
labels
Apr 22, 2020
9 tasks
johlju
added
help wanted
The issue is up for grabs for anyone in the community.
and removed
help wanted
The issue is up for grabs for anyone in the community.
labels
Apr 29, 2020
9 tasks
johlju
added a commit
that referenced
this issue
May 5, 2020
- SqlServerDsc - Added new resource SqlServerProtocolTcpIp (issue #1378). - Changed to use the property `NuGetVersionV2` from GitVersion in the CI pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This resource should manage IP address groups.
IP Address groups are added depending on available network cards, see Adding or Removing IP Addresses. In my lab server I only have IP1-IP6 and IPAll. But in a test server with a cluster I have IP1-IP8 and IPAll.
So we cannot support adding and removing IP address groups, but I think we should support managing IP address groups with this resource. For that reason I see a need
for a
IpAddressGroup
parameter that is mentioned in the #339 (comment). The user can then choose which group should have which IP address, and if it should be enabled or not. This resource will most likely be used to change the IP addresses to different once that wasn't used during installation, or configure additional ones when network configuration changes.It would be good to be able to support all these properties. The property
Active
seems to be read-only.Proposed properties
Special considerations or limitations
This is a redesign of the resource
SqlServerNetwork
and splitting it up into two new resources will simplify the code and therefore easier to maintain. This resource could be added side-by-side withSqlServerNetwork
and together withSqlServerProtocol
will deprecate the resourceSqlServerNetwork
.This was discussed in closed PR #1045.
The text was updated successfully, but these errors were encountered: