-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServerProtocolTcpIp: New resource proposal #1517
Merged
johlju
merged 20 commits into
dsccommunity:master
from
johlju:f/add-resource-SqlServerProtocolTcpIP
May 5, 2020
Merged
SqlServerProtocolTcpIp: New resource proposal #1517
johlju
merged 20 commits into
dsccommunity:master
from
johlju:f/add-resource-SqlServerProtocolTcpIP
May 5, 2020
+2,609
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
539f484
to
429a0cc
Compare
6fc3fbd
to
2a50f8c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1517 +/- ##
=======================================
Coverage 98% 98%
=======================================
Files 39 40 +1
Lines 5878 6027 +149
=======================================
+ Hits 5780 5930 +150
+ Misses 98 97 -1 |
65dac30
to
09b2c20
Compare
johlju
commented
May 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 20 of 20 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This is dependent on that PR #1511 is merged first, after that this PR should be rebased!
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is