Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerProtocolTcpIp: New resource proposal #1517

Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented May 3, 2020

Pull Request (PR) description

This is dependent on that PR #1511 is merged first, after that this PR should be rebased!

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju changed the title F/add resource sql server protocol tcp ip SqlServerProtocolTcpIp: New resource proposal May 3, 2020
@johlju johlju added on hold The issue or pull request has been put on hold by a maintainer. needs review The pull request needs a code review. and removed on hold The issue or pull request has been put on hold by a maintainer. labels May 3, 2020
@johlju johlju force-pushed the f/add-resource-SqlServerProtocolTcpIP branch from 539f484 to 429a0cc Compare May 3, 2020 07:11
@johlju johlju force-pushed the f/add-resource-SqlServerProtocolTcpIP branch 5 times, most recently from 6fc3fbd to 2a50f8c Compare May 3, 2020 15:11
@codecov
Copy link

codecov bot commented May 3, 2020

Codecov Report

Merging #1517 into master will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1517    +/-   ##
=======================================
  Coverage      98%     98%            
=======================================
  Files          39      40     +1     
  Lines        5878    6027   +149     
=======================================
+ Hits         5780    5930   +150     
+ Misses         98      97     -1     

@johlju johlju force-pushed the f/add-resource-SqlServerProtocolTcpIP branch from 65dac30 to 09b2c20 Compare May 4, 2020 05:48
@johlju johlju marked this pull request as ready for review May 4, 2020 05:48
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 20 of 20 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 83760fe into dsccommunity:master May 5, 2020
@johlju johlju deleted the f/add-resource-SqlServerProtocolTcpIP branch May 5, 2020 09:04
@johlju johlju removed the needs review The pull request needs a code review. label May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlServerProtocolTcpIp: New resource proposal
1 participant