Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-ServiceAccountRequirePassword: Move to DscResource.Common as a public command #1794

Closed
johlju opened this issue Nov 24, 2022 · 1 comment · Fixed by #1828
Closed

Test-ServiceAccountRequirePassword: Move to DscResource.Common as a public command #1794

johlju opened this issue Nov 24, 2022 · 1 comment · Fixed by #1828
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Nov 24, 2022 •
edited
Loading

We should look at moving this to DscResource.Common (as a public command). Maybe change from "ServiceAccount" to the more generic "Account" in the public command.
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Nov 24, 2022
This was referenced Dec 29, 2022
Closed
Merged
johlju added a commit to dsccommunity/DscResource.Common that referenced this issue Dec 30, 2022
@johlju
Add Assert-RequiredCommandParameter and `Test-AccountRequirePasswor…
052cfde 
…d` (#94)

- Added private function `Assert-RequiredCommandParameter` that throws an
  exception if a specified parameter is not assigned a value, and optionally
  throws only if a specific parameter is passed. - [Issue #92](#92)
  - Related to SqlServerDsc [Issue #1796](dsccommunity/SqlServerDsc#1796).
- Added public function `Test-AccountRequirePassword` that returns true or
  false whether an account need a password to be passed - [Issue #93](#93)
  - Related to SqlServerDsc [Issue #1794](dsccommunity/SqlServerDsc#1794).
- DscResource.Common
  - Updated Visual Studio Code project settings to configure testing for Pester 5.
- `Assert-BoundParameter`
  - Now has a new parameter set that calls `Assert-RequiredCommandParameter`
    which will throw an exception if a specified parameter is not assigned
    a value, and optionally throws only if a specific parameter is passed.
- Fixed unit tests for `Assert-ElevatedUser` and `Test-IsNumericType` so
  the public function is tested correctly using the exported function.
@johlju
Copy link
Member Author

johlju commented Dec 30, 2022

The command has been renamed to Test-AccountRequirePassword when merged into DscResource.Common.

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jan 1, 2023
@johlju johlju mentioned this issue Jan 1, 2023
Merged
9 tasks
johlju added a commit that referenced this issue Jan 2, 2023
@johlju
Assert-SetupActionProperties: Use commands from DscResource.Common (#…
2408ab5 
…1828)

- SqlServerDsc
  - Removed `Test-ServiceAccountRequirePassword` from private functions (issue #1794)
    - Replaced by `Test-AccountRequirePassword` that was added to _DscResource.Common_
      public functions ([issue #93](dsccommunity/DscResource.Common#93)).
  - Removed `Assert-RequiredCommandParameter` from private functions (issue #1796).
    - Replaced by `Assert-BoundParameter` (part of _DscResource.Common_)
      that had a new parameter set added ([issue #92](dsccommunity/DscResource.Common#92)).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Assert-SetupActionProperties: Use commands from DscResource.Common johlju/SqlServerDsc
1 participant
@johlju