Pester Tests Need to be implemented for all existing Modules

[aultt]

We need additional people to help write Pester tests. This is a requirement to take the resource out of experimental status.

[johlju]

Note: We are also discussing mocking in issue #90

[johlju]

I on task to fix tests for xSQLServerEndpointState, xSQLServerAvailabilityGroupListener and xSQLServerEndpointPermission.

[aultt]

xSQLServerPermission is also failing in the build. Doesn't look like it was tested when you did the intial push

[johlju]

The test was actually tested successfully by AppVoyer. The PR did not fail the tests (it wouldn't been merged otherwise I belive). Strange that it fails when it's tested together with your new tests. Does all tests work together in your dev environment?

@mbreakey3 Can you see why the tests fail? The error message (the types) failling from the resource aren't anywhere close to what's used in the resource. So it feels strange.

[mbreakey3]

Yeah, so the build that shows up for xSqlServer is actually from Master, not Dev. John's merge did run successfully actually. We're still looking into other causes for why this might be happening.

[johlju]

I have a new test finished (one, of the three I set out to do, is done). I can send in a PR of that test I got if that helps to debug.
Otherwise I wait until I got all three ready. :)

[mbreakey3]

Is it for one of the resources that already has a test file?

[johlju]

No, it's a new one, for the resource xSQLServerEndpointState

[johlju]

Correction. It will send in a new version of the existing test as well, because I did small changes in it.

[mbreakey3]

Okay, I think it would probably be best to just roll it into one PR once you finish the other tests, and we'll try to get this issue figured out in the mean time.

[johlju]

Will do. Fixing rest of the test.

[aultt]

Currently have xSQLAOGroupJoin test complete moving on the xSQLDatabaseRecoveryModel next then to xSQLServerAlwayONService and working the way down the list.

[johlju]

New test in PR #106 for xSqlServerLogin

[johlju]

Working on a test for xSQLServerDatabaseRole. Will PR this weekend.

[luigilink]

New test in PR #138 for MSFT_xSQLServerDatabaseOwner

[luigilink]

New test in PR #140 for MSFT_xSQLServerDatabasePermissions

[johlju]

@luigilink Great work!! 😄

[nabrond]

Tests for xSQLServerConfiguration are in PR #143

[luigilink]

@aultt could you add the status of test development in issue description:
17 Pester Test / 28 DSC Resources

• MSFT_xSQLAOGroupEnsure
• MSFT_xSQLAOGroupJoin
• MSFT_xSQLDatabaseRecoveryModel
• MSFT_xSQLServerAlias
• MSFT_xSQLServerAlwaysOnService
• MSFT_xSQLServerAvailabilityGroupListener
• MSFT_xSQLServerConfiguration
• MSFT_xSQLServerDatabase
• MSFT_xSQLServerDatabaseOwner
• MSFT_xSQLServerDatabasePermissions
• MSFT_xSQLServerDatabaseRole
• MSFT_xSQLServerEndpoint
• MSFT_xSQLServerEndpointPermission
• MSFT_xSQLServerEndpointState
• MSFT_xSQLServerFailoverClusterSetup
• MSFT_xSQLServerFirewall
• MSFT_xSQLServerLogin
• MSFT_xSQLServerMaxDop
• MSFT_xSQLServerMemory
• MSFT_xSQLServerNetwork
• MSFT_xSQLServerPermission
• MSFT_xSQLServerReplication
• MSFT_xSQLServerRole
• MSFT_xSQLServerRSConfig
• MSFT_xSQLServerRSSecureConnectionLevel
• MSFT_xSQLServerScript
• MSFT_xSQLServerSetup
• MSFT_xWaitForAvailabilityGroup

Update:
MSFT_xSQLServerPowerPlan removed from this list
MSFT_xSQLServerAlias renamed
List Updated

[johlju]

I added those I have in PR.

MSFT_xSQLServerPowerPlan we can skip, it's being moved. So it will be removed from this module as soon it is merged in repo xComputerManagement.

[johlju]

I closing this issue, and instead I open a new issue for each resource.