Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall-SqlDscServer: Does not support argument SuppressPrivacyStatementNotice #1809

Closed
johlju opened this issue Nov 29, 2022 · 5 comments · Fixed by #1851
Closed

Uninstall-SqlDscServer: Does not support argument SuppressPrivacyStatementNotice #1809

johlju opened this issue Nov 29, 2022 · 5 comments · Fixed by #1851
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Nov 29, 2022

Problem description

When using the cmmand Uninstall-SqlDscServer it is not possible to suppress the privacy statement notice.

Verbose logs

PS C:\Windows\system32> Uninstall-SqlDscServer -MediaPath e:\ -InstanceName 'SQL2019' -Features 'SQLENGINE' -Verbose
VERBOSE: Specified setup executable arguments: /QUIET /ACTION=Uninstall /INSTANCENAME="SQL2019" /FEATURES=SQLENGINE

Invoke a Microsoft SQL Server setup action
Are you sure you want to invoke the setup action 'Uninstall'?
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "Y"): y
VERBOSE: Started the process with id 6968 using the path 'e:\setup.exe', and with a timeout value of 7200 seconds.
(SQLCOMMON0017)
Microsoft (R) SQL Server 2019 15.00.2000.05
Copyright (c) 2019 Microsoft.  All rights reserved.

SQL Server 2019 transmits information about your installation experience, as well as other usage and performance data, to Microsoft to help improve the product. To learn more about SQL Server 2019 data processing and privacy controls, please see the Privacy Statement.
The following error occurred:
Instance Name SQL2019 for product Microsoft SQL Server doesn't exist. Specify a valid instance name.

How to reproduce

On every run with the command, for example:

Uninstall-SqlDscServer -MediaPath e:\ -InstanceName 'SQL2019' -Features 'SQLENGINE'

Expected behavior

Should have an option to suppress the privacy statement notice.

Current behavior

No option to suppress the privacy statement notice.

Suggested solution

Add the parameter SuppressPrivacyStatementNotice to the command Uninstall-SqlDscServer and add the parameter to the Uninstall parameter set in the command Invoke-Setup.

Operating system the target node is running

Any

PowerShell version and build the target node is running

n/a

Module version used

Main branch.
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Nov 29, 2022
@bleakprestiger
Copy link
Contributor

@johlju can you please also assign this task to me ?

@johlju
Copy link
Member Author

johlju commented Dec 4, 2022

Done. Looking forward to a PR. 😊

@johlju
Copy link
Member Author

johlju commented Dec 18, 2022

@bleakprestiger are you still on this?

@bleakprestiger
Copy link
Contributor

Yes

@johlju
Copy link
Member Author

johlju commented Jan 22, 2023

@bleakprestiger I have not seen and PR for this for over a month. I will remove the assignment within a week unless I see a PR, so someone else can work on this.

@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Feb 12, 2023
johlju added a commit that referenced this issue Feb 12, 2023
…entNotice` (#1851)

- `Uninstall-SqlDscServer`
  - Now support the argument `SuppressPrivacyStatementNotice` (issue #1809).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants