Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall-SqlDscServer: Now support argument SuppressPrivacyStatementNotice #1851

Merged
merged 2 commits into from
Feb 12, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Feb 11, 2023

Pull Request (PR) description

  • Uninstall-SqlDscServer
    • Now support the argument SuppressPrivacyStatementNotice (issue #1809).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Feb 11, 2023
@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #1851 (fc7c5a9) into main (ea2a62a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1851   +/-   ##
====================================
  Coverage    91%     91%           
====================================
  Files        73      73           
  Lines      7367    7367           
====================================
  Hits       6717    6717           
  Misses      650     650           
Flag Coverage Δ
unit 91% <ø> (ø)
Impacted Files Coverage Δ
source/Public/Uninstall-SqlDscServer.ps1 100% <ø> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju added this pull request to the merge queue Feb 12, 2023
@johlju johlju removed the needs review The pull request needs a code review. label Feb 12, 2023
@johlju johlju removed this pull request from the merge queue due to a manual request Feb 12, 2023
@johlju johlju enabled auto-merge (squash) February 12, 2023 12:23
@johlju johlju merged commit 7a4620d into dsccommunity:main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninstall-SqlDscServer: Does not support argument SuppressPrivacyStatementNotice
1 participant