-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlAgDatabase: Typo in resource for fix for #1492 #1666
Conversation
Style guideline fixes and move change log entries
…all test for this.
updating master
SqlServerMaxDop: Fix for dsccommunity#396 (dsccommunity#1644)
SqlProtocol: Changes datatype for schema property KeepAlive (dsccommunity#1646)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
Great catch of @Jens-Sjolund. Seems we are missing a unit test to catch that scenario? We can look at that when we convert the tests to Pester 5. I merge this without a unit test for now. Thanks for fixing this @Fiander! |
No problem, i did make the mistake, so why not fix it ? @johlju can i edit the unit tests, to add a row where it states we mis a test for this scenario? else we might forget it |
@Fiander If you like, then please add a unit test that covers this scenario. 🙂 |
Codecov Report
@@ Coverage Diff @@
## main #1666 +/- ##
======================================
Coverage ? 97%
======================================
Files ? 38
Lines ? 6257
Branches ? 0
======================================
Hits ? 6100
Misses ? 157
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
turns out, the test was already there, just not correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Fiander!
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Fix #1492 Typo.
at row 450 was a typo.
$backupNeeded <> $needsBackup
$backupNeeded is correct, found thanks to @Jens-Sjolund
#1492 (comment)
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is