[test] Add missing types linting for x-grid (mui#357)

dtassone · Nov 9, 2020 · b059063 · b059063
1 parent cbd62d9
commit b059063
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/packages/grid/data-grid/src/DataGrid.test.tsx b/packages/grid/data-grid/src/DataGrid.test.tsx
@@ -1,7 +1,7 @@
 /* eslint-disable react/forbid-foreign-prop-types */
 import * as React from 'react';
 import PropTypes from 'prop-types';
-// @ts-ignore
+// @ts-expect-error need to migrate helpers to TypeScript
 import { createClientRender, ErrorBoundary } from 'test/utils';
 import { expect } from 'chai';
 import { DataGrid } from '@material-ui/data-grid';

diff --git a/packages/grid/x-grid/package.json b/packages/grid/x-grid/package.json
@@ -24,6 +24,12 @@
     "datagrid",
     "data-grid"
   ],
+  "scripts": {
+    "precommit": "npm run lint",
+    "lint": "../../../node_modules/.bin/tsc --noEmit && eslint 'src/**/*.{ts,tsx}' --quiet --fix -c ../../../.eslintrc.js && npm run lint:css",
+    "lint:css": "stylelint 'src/**/*.{ts,tsx}' ../../../.stylelintrc.js",
+    "typescript": "tsc -p tsconfig.json"
+  },
   "dependencies": {
     "@material-ui/x-license": "^4.0.0-alpha.6",
     "prop-types": "^15.7.2",
@@ -34,11 +40,6 @@
     "@material-ui/core": "^4.9.12",
     "react": "^16.8.0"
   },
-  "scripts": {
-    "precommit": "npm run lint",
-    "lint": "../../../node_modules/.bin/tsc --noEmit && eslint 'src/**/*.{ts,tsx}' --quiet --fix -c ../../../.eslintrc.js && npm run lint:css",
-    "lint:css": "stylelint 'src/**/*.{ts,tsx}' ../../../.stylelintrc.js"
-  },
   "setupFiles": [
     "<rootDir>/src/setupTests.js"
   ],

diff --git a/packages/grid/x-grid/src/XGrid.test.tsx b/packages/grid/x-grid/src/XGrid.test.tsx
@@ -1,4 +1,5 @@
 import * as React from 'react';
+// @ts-expect-error need to migrate helpers to TypeScript
 import { screen, createClientRender, act, fireEvent } from 'test/utils';
 import { expect } from 'chai';
 import { XGrid, useApiRef } from '@material-ui/x-grid';
@@ -74,7 +75,7 @@ describe('<XGrid />', () => {
   // Adapation of describeConformance()
   describe('Material-UI component API', () => {
     it(`attaches the ref`, () => {
-      const ref = React.createRef();
+      const ref = React.createRef<HTMLDivElement>();
       const { container } = render(
         <div style={{ width: 300, height: 300 }}>
           <XGrid {...defaultProps} ref={ref} />