[test] Add missing types linting for x-grid #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtassone
reviewed
Sep 28, 2020
dtassone
reviewed
Sep 28, 2020
| @@ -24,6 +24,12 @@ | |||
| "datagrid", | |||
| "data-grid" | |||
| ], | |||
| "scripts": { | |||
| "precommit": "npm run lint", | |||
| "lint": "../../../node_modules/.bin/tsc --noEmit && eslint 'src/**/*.{ts,tsx}' --quiet --fix -c ../../../.eslintrc.js && npm run lint:css", | |||
There was a problem hiding this comment.
Not sure it's still useful the lint script here, if we need to lint from the root folder
There was a problem hiding this comment.
No strong preferences. We lint eslint from the root but typescript from each package. I personally never run eslint from the CLI (always in the CI and IDE). I run TypeScript from time to time in the CLI and in nested folders as it has cross-file dependencies. Happy to only have eslint at the root.
oliviertassinari
force-pushed
the
lint-x-grid-tests
branch
from
65add3a to
2d1b29c
Compare
dtassone
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.