Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.rs checks for CARGO_RUSTC_WRAPPER which does not seem to be a thing #248

Closed
RalfJung opened this issue Aug 2, 2022 · 2 comments · Fixed by #249
Closed

build.rs checks for CARGO_RUSTC_WRAPPER which does not seem to be a thing #248

RalfJung opened this issue Aug 2, 2022 · 2 comments · Fixed by #249

Comments

@RalfJung
Copy link
Contributor

RalfJung commented Aug 2, 2022

There is an env var called RUSTC_WRAPPER, but the build script looks for CARGO_RUSTC_WRAPPER which I cannot find anywhere in the cargo docs or source. Is that a typo?

let mut cmd = if let Some(wrapper) = env::var_os("CARGO_RUSTC_WRAPPER") {

@dtolnay
Copy link
Owner

dtolnay commented Aug 2, 2022

This was added by @jonhoo in #157.

I guess it used to be a thing?

$ git log -S CARGO_RUSTC_WRAPPER

commit 715fab4ff508d96fdbcc7d1b89e562397b5584a4
Author: Jon Gjengset <jongje@amazon.com>
Date:   Fri Jun 25 09:23:32 2021 -0700

    Update docs

commit 1e407453c2e382ff94c06bb03ab7336c8e1efd95
Author: Jon Gjengset <jongje@amazon.com>
Date:   Thu Jun 24 09:55:57 2021 -0700

    Remove CARGO_ prefix for new build script envvars

commit 8012d328ee1559ce5ddf519e7d0611fddb20d739
Author: Jon Gjengset <jongje@amazon.com>
Date:   Fri Jun 18 12:40:29 2021 -0700

    Avoid coercing path to string for windows

commit 719eb593c8e167b07caf33a2b23bddd085d3b1d9
Author: Jon Gjengset <jongje@amazon.com>
Date:   Fri Jun 18 12:14:58 2021 -0700

    Add tests for rustc context build script env vars

commit 44491ee8a64c0a861315bb6986e4345398d917e0
Author: Jon Gjengset <jongje@amazon.com>
Date:   Fri Jun 18 11:59:06 2021 -0700

    Document build script envvars for rustc context

commit 6ee606be69c7175a3974d3ecbf47f2b44f003047
Author: Jon Gjengset <jongje@amazon.com>
Date:   Fri Jun 18 11:49:12 2021 -0700

    Inform build scripts of rustc compiler context
    
    Fixes #9600.

@RalfJung
Copy link
Contributor Author

RalfJung commented Aug 2, 2022

Yes it got removed during PR discussion and looks like that was never reflected into the anyhow PR.

sunfishcode added a commit to bytecodealliance/rustix that referenced this issue Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER`
instead of `CARGO_RUSTC_WRAPPER`.

[here]: #544 (comment)
sunfishcode added a commit to bytecodealliance/rustix that referenced this issue Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER`
instead of `CARGO_RUSTC_WRAPPER`.

[here]: #544 (comment)
sunfishcode added a commit to sunfishcode/io-lifetimes that referenced this issue Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`.

[here]: bytecodealliance/rustix#544 (comment)
sunfishcode added a commit to sunfishcode/io-lifetimes that referenced this issue Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`.

[here]: bytecodealliance/rustix#544 (comment)
sunfishcode added a commit to bytecodealliance/cap-std that referenced this issue Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`.

[here]: bytecodealliance/rustix#544 (comment)
sunfishcode added a commit to bytecodealliance/rustix that referenced this issue Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER`
instead of `CARGO_RUSTC_WRAPPER`.

[here]: #544 (comment)
sunfishcode added a commit to bytecodealliance/cap-std that referenced this issue Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`.

[here]: bytecodealliance/rustix#544 (comment)
sunfishcode added a commit to bytecodealliance/cap-std that referenced this issue Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`.

[here]: bytecodealliance/rustix#544 (comment)
sunfishcode added a commit to bytecodealliance/rustix that referenced this issue Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER`
instead of `CARGO_RUSTC_WRAPPER`.

[here]: #544 (comment)
sunfishcode added a commit to bytecodealliance/cap-std that referenced this issue Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`.

[here]: bytecodealliance/rustix#544 (comment)
sunfishcode added a commit to bytecodealliance/rustix that referenced this issue Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER`
instead of `CARGO_RUSTC_WRAPPER`.

[here]: #544 (comment)
sunfishcode added a commit to bytecodealliance/rustix that referenced this issue Oct 12, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER`
instead of `CARGO_RUSTC_WRAPPER`.

[here]: #544 (comment)
sunfishcode added a commit to bytecodealliance/rustix that referenced this issue Oct 12, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER`
instead of `CARGO_RUSTC_WRAPPER`.

[here]: #544 (comment)
sunfishcode added a commit to bytecodealliance/rustix that referenced this issue Oct 12, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER`
instead of `CARGO_RUSTC_WRAPPER`.

[here]: #544 (comment)
sunfishcode added a commit to bytecodealliance/rustix that referenced this issue Oct 12, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER`
instead of `CARGO_RUSTC_WRAPPER`.

[here]: #544 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants