Include Cargo rustc configuration in probe #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to reflect the change that landed in rust-lang/cargo#9601. Have confirmed that this fixes the problem when using nightly cargo. |
Without this, environments that configure `RUSTFLAGS` or the `RUSTC_WRAPPER` in ways that break compilation with `backtrace` will fail to compile anyhow (see dtolnay#156). With this, the compiler probe takes into account that Cargo configuration, and thus (more) accurately represents whether the `backtrace` feature can be safely enabled. Requires rust-lang/cargo#9601, but does not break without. Fixes dtolnay#156.
|
You may need to kick CI again — I missed a case that caused nightly builds where RUSTFLAGS was empty to fail, and GitHub Actions doesn't remember the CI approval. |
This was referenced Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, environments that configure
RUSTFLAGSor theRUSTC_WRAPPERin ways that break compilation withbacktracewill fail to compile anyhow (see #156).With this, the compiler probe takes into account that Cargo configuration, and thus (more) accurately represents whether the
backtracefeature can be safely enabled.Tested using the problematic configuration from #156 with the Cargo fix from rust-lang/cargo#9601, and anyhow correctly decides not to enable
backtraceand thus compiles.Requires rust-lang/cargo#9601, but does not break without.
Fixes #156.