-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes for weights and vertices #77
Open
Devostated
wants to merge
7
commits into
dtzxporter:cast-c4d-cleanup
Choose a base branch
from
Devostated:cast-c4d-cleanup
base: cast-c4d-cleanup
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Minor changes for weights and vertices #77
Devostated
wants to merge
7
commits into
dtzxporter:cast-c4d-cleanup
from
Devostated:cast-c4d-cleanup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue that was related to reading the values of the weightTag Error: > Joint index out of range Solution dtzxporter#1: Inserting the weightTag before reading it's values. Solution dtzxporter#2: ```diff - boneIndexes[bone.Hash()] = newBone + boneIndexes[bone.Hash() or i] = newBone ``` This solution was only needed for Apex Legends models, which seem to not always have a bone hash?
3d65185
to
a649632
Compare
The integer vertexCount is 1/3 of vertexPositions, so the loop only sets 1/3 of the vertices.
dtzxporter
requested changes
Nov 12, 2024
Due to Cinema4Ds layer usage, we have to apply the material tag right after the first UV tag was added.
It can't be index and bone.Hash() Solution: using bone.Name() instead
Do you still need help with this one? |
Notifying the user if an instance failed to import.
Only the animation support is left to do, unless you notice anything else. |
An rotation error in the imported skeletons of CoD models has been found and solved together with @dtzxporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertices:
The integer vertexCount is 1/3 of vertexPositions, so the loop only sets 1/3 of the vertices.
Weights:
Fixed an issue that was related to reading the values of the weightTag
Error:
Solution #1:
Inserting the weightTag before reading it's values.
Solution #2:
This solution was only needed for Apex Legends models, which seem to not always have a bone hash?