Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: token denom handling for IBC tokens on testnet #516

Merged
merged 52 commits into from
Jan 24, 2024
Merged

fix: token denom handling for IBC tokens on testnet #516

merged 52 commits into from
Jan 24, 2024

Conversation

dib542
Copy link
Collaborator

@dib542 dib542 commented Jan 23, 2024 •
edited
Loading

This PR fixes the usage of assets/tokens in the app from using a master list of "all possible" tokens to using "runtime" tokens: token information from up to date chain-registry package information on GitHub.

previously:

  • token list was derived from all active chain IBC connections cross-referenced with static chain-registry package data

now:

  • token lists are derived as needed at runtime from current chain-registry package data in GitHub
    • the context of which tokens should be queried for needs to be provided in terms of native chain denom strings:
      eg. useTokens(['untrn','ibc/27394FB092D2ECCD56123C74F36E4C1F926001CEADA9CA97EA622B25F41E5EB2'])
  • chain information is derived as needed at runtime from current chain-registry package data in GitHub

Note that the build for this release is intended to be skipped, as the code no longer works against duality-devnet: rpc.dev.duality.xyz and lcd.dev.duality.xyz.

@dib542 dib542 linked an issue Jan 23, 2024 that may be closed by this pull request
Improve token/denom handling for IBC tokens #509
Closed
@dib542 dib542 force-pushed the 509-improve-token-denom-handling-for-ibc-tokens branch from 1c81d92 to 8195c82 Compare January 23, 2024 10:29
This was referenced Jan 23, 2024
Merged
Merged
Merged
@dib542 dib542 force-pushed the 509-improve-token-denom-handling-for-ibc-tokens branch from 8195c82 to f68dc5a Compare January 23, 2024 22:06
dib542 added 24 commits January 24, 2024 08:12
@dib542
feat: use at-runtime chain fee token for fee display on LimitOrderCard
6b1a62e
@dib542
feat: remove STK and TKN dev tokens:
9347e51 
    - for local dev tokens: DEV_ASSET_MAP can still be used
@dib542
docs: improve example of using IBC tokens using a provider chain locally
ca3e753
@dib542
feat: rename dualityChain to more neutral nativeChain
3c6ebd0
@dib542
feat: base nativeChain off matching chain-registry chain name
77448f2
@dib542
feat: add whole chain context into IBC transfer data
f91dff7
@dib542
fix: align @chain-registry/types deep dependencies to ^0.17.1
efbb977
@dib542
feat: allow env chain list instead of one specific provider chain
353777c
@dib542
fix: create and use one main assetLists
d441aa1
@dib542
feat: restrict Bridge table to native and bridgable assets
3899a95
@dib542
feat: make Bridge page less confusing, disable bridge when no wallet
4356593
@dib542
feat: show but disable Bridge button if addresses are not connected
5f22397
@dib542
fix: IBC withdrawals reference to wrong client ID
b84f973
@dib542
fix: allow all IBC tokens of any channel to be viewed in Bridge page
9b4b382 
    - previously only one IBC channel was selected per chain ID
    - now all channels are used
@dib542
fix: refer to most tokens by denom for more specificity:
2ceab59 
    - need to be specific to be able to select a specific IBC denom
      of a token than has multiple IBC denoms, possibly even
      connecting the same chains over different connections
@dib542
fix: avoid IBC token pair error with REST lookup by using poolById
ebf088a
@dib542
fix: change useEstimatedUserReserves to use denoms instead of tokens
eed2e50
@dib542
feat: add chain-registry utility package for denom help
62125ff
@dib542
feat: add chain-registry client dependency
66e710b
@dib542
feat: add hook to get chain-registry client and asset lists
9fd1590
@dib542
feat: allow multiple chain-registry endpoints to be data sources
c2deb63
@dib542
chore: correct the fee tokens allowed on testnet and production
114bc26
@dib542
feat: add useTracedAsset to find deep asset detail for any denom
39be29b
@dib542
fix: useDenomsFromChain needs size to be set and updated
6c486c0
@dib542 dib542 force-pushed the 509-improve-token-denom-handling-for-ibc-tokens branch from f68dc5a to 101a334 Compare January 23, 2024 22:40
@github-actions GitHub Actions
Copy link

Preview URL: https://101a3344-bf00f050--duality-xyz.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz/deploys/65b0411e6744870873f8336e

@dib542 dib542 force-pushed the 509-improve-token-denom-handling-for-ibc-tokens branch from af0bf51 to 968731a Compare January 24, 2024 00:47
@dib542 dib542 changed the title fix: improve token denom handling for IBC tokens fix: token denom handling for IBC tokens on testnet Jan 24, 2024
@github-actions GitHub Actions
Copy link

Preview URL: https://968731a3-ff441baa--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/65b05efa5d5cce1aabdb9221

@dib542 dib542 force-pushed the 509-improve-token-denom-handling-for-ibc-tokens branch from 968731a to a9ed6dd Compare January 24, 2024 01:21
@github-actions GitHub Actions
Copy link

Preview URL: https://a9ed6dd9-76fbec98--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/65b066b576de6b1b4f46d9e2

@dib542 dib542 force-pushed the 509-improve-token-denom-handling-for-ibc-tokens branch from a9ed6dd to b8eacf2 Compare January 24, 2024 01:30
@github-actions GitHub Actions
Copy link

Preview URL: https://b8eacf22-ce4aee0d--duality-xyz-testnet.netlify.app
Logs: https://app.netlify.com/sites/duality-xyz-testnet/deploys/65b068f31914bd1f13eb68ed

@dib542 dib542 merged commit 2265fe9 into main Jan 24, 2024
1 of 2 checks passed
@dib542 dib542 deleted the 509-improve-token-denom-handling-for-ibc-tokens branch January 24, 2024 01:34
dib542 pushed a commit that referenced this pull request Jan 24, 2024
@semantic-release-bot
chore(release): 1.0.1 [skip ci]
13a6d53 
## [1.0.1](v1.0.0...v1.0.1) (2024-01-24)

### Fixes

* token denom handling for IBC tokens on testnet ([#516](#516)) ([2265fe9](2265fe9))
@dib542
Copy link
Collaborator Author

dib542 commented Jan 24, 2024

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve token/denom handling for IBC tokens
1 participant
@dib542