Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve token denom handling for IBC tokens: part 2b #519

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

dib542
Copy link
Collaborator

@dib542 dib542 commented Jan 23, 2024

This PR aims to clean up some fixes before merging:

In particular this PR refactors cleans up several small issues identified during the main PR to merge after

  • fixed: change IBC data fetch hooks to download all pages of data, instead of just one page
  • a helper from the above fix is used in several places to simplify the loading of all pages for other resources

@dib542 dib542 force-pushed the 509-improve-token-denom-handling-for-ibc-tokens-part-2b branch from 7c5d4a3 to 69835c4 Compare January 23, 2024 21:57
@dib542 dib542 merged commit 1be359a into main Jan 23, 2024
2 of 3 checks passed
@dib542 dib542 deleted the 509-improve-token-denom-handling-for-ibc-tokens-part-2b branch January 23, 2024 22:03
dib542 pushed a commit that referenced this pull request Jan 23, 2024
## [0.3.52](v0.3.51...v0.3.52) (2024-01-23)

### Fixes

* fetch all paginated pages of some resources ([#519](#519)) ([1be359a](1be359a))
@dib542
Copy link
Collaborator Author

dib542 commented Jan 23, 2024

🎉 This PR is included in version 0.3.52 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dib542 dib542 linked an issue Jan 31, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve token/denom handling for IBC tokens
1 participant