Set nulls correctly for all type of arrays/vectors #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* set nulls for all possible array to vectors * add more set nulls * wip * only change flat vector * Revert "only change flat vector" This reverts commit 90c9d75. * add list vector nulls
Swoorup
reviewed
Jun 21, 2024
|
Thanks for the PR! LGTM - could you just merge with main so the CI can rerun? |
|
Thanks - looks like the CI now fails on the newly added test. Could you have a look when you have time? |
|
yeah, will do. Sorry got carried away by something else, looks like an easy fix. |
|
that's still something wrong with invalid cfg feature for time. Which is not introduced by this branch, I took a shot on fixing that but not really sure how the |
|
Thanks for looking into it - could you merge with main again? The CI should be fixed again in #375 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the correct nulls for strings, struct, list, array types when copying data from arrow array to duckdb vectors.
When inserting nulls to columns with these types, the null will be correctly set instead of the default value like:
"",{k: ""}, etc.