Fix CI #375
Merged
Fix CI #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could also remove https://github.com/duckdb/duckdb-rs/blob/main/crates/duckdb/src/util/small_cstr.rs As its not used anywhere. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Mytherin I think this solves the CI issues, likely something changed upstream making clippy more strict.
I've removed the
timefeature completely. It doesn't appear to be used anywhere and seems like a leftover from copying rusqlite stuff. Also remove the large comment which is just copied from rusqlite and is just confusing overall:DuckDB uses a [dynamic type system](https://www.sqlite.org/datatype3.html)I just wanted to restore CI here quickly, but i think we should look into more thoroughly trimming dead features/code from the package. I feel there's a lot of stuff that is not really used and could potentially be removed to make the package easier to understand.