Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streaming arrow data support #373

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

y-f-u
Copy link
Contributor

@y-f-u y-f-u commented Aug 19, 2024

This PR adds a new execute_streaming method in Statement and a ArrowStream struct to support streaming arrow data rather than fetching all in one call.

This has a caveat that require a SchemaRef to be passed into the ArrowStream struct as I couldn't find a way to get the schema without fetching entire batches.

Please point out if anyone knows

This fixes #171

* streaming

* remove invalid schema assign

* use ArrowStream type to represent streaming

* clippy

* doc

* import

* typo

* export arrow stream
@Mytherin
Copy link
Contributor

Thanks for the PR! Could you merge with main so that the CI can rerun?

@Mytherin
Copy link
Contributor

The current CI failure looks to be related to the actual changes made in the PR. Could you have a look?

@peasee
Copy link
Contributor

peasee commented Aug 28, 2024

The current CI failure looks to be related to the actual changes made in the PR. Could you have a look?

Should be fixed now! I've tested the workflow in our fork which passed 😃

@hozan23
Copy link

hozan23 commented Sep 24, 2024

Hello,

Any updates on this PR? @y-f-u @Mytherin

@Mytherin Mytherin merged commit e12fdb6 into duckdb:main Sep 26, 2024
4 checks passed
@Mytherin
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support streaming query
4 participants