-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase spiceai onto main branch #112
base: main
Are you sure you want to change the base?
Rebase spiceai onto main branch #112
Conversation
* wip * duckdb streaming * clippy * arrow to arrow stream * error message * fix: Support `INTERVAL` in SQLite (datafusion-contrib#85) * poc: Support interval in SQLite using an AST analyzer * Refactoring * u64 -> i64 * fix: Support INTERVAL expressions in SQLite * docs: Add comment about flattening arguments list * refactor: Rename SQLiteVisitor to SQLiteIntervalVisitor * test: Add some tests --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech> * Use DuckDB streaming * Fixes * Fix feature flagging * Fix lint * Add spiceai branch to pull_request --------- Co-authored-by: peasee <98815791+peasee@users.noreply.github.com> Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
…fusion-contrib#88) * SQLite: Validate expected indexes when attaching local datasets * Add test for indexes creation and retrieval (SQLite) * Update warning messages
* fix: Don't silence blocking task errors * fix: Cover Ok(Err()) match arm for DuckDB writer handle * refactor: Rename overloaded error e
* fix: Re-attach databases on each query * Update src/sql/db_connection_pool/dbconnection/duckdbconn.rs --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
…ontrib#96) * Correctly handle mysql timestamp() and datetime() types * Restructure MySQL test, add test for timestamp() types * Include test for datetime types
* Postgres enum support * Add enum test as part of integration test * update * Remove the duplicate function * fix --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
postgres-federation = ["postgres"] | ||
|
||
[patch.crates-io] | ||
duckdb = { git = "https://github.com/spiceai/duckdb-rs.git", rev = "f2ca47d094a5636df8b9f3792b2f474a7b210dc1" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to replace this with the crate version.
We should keep this PR open, and upstream the changes from spiceai/duckdb-rs to duckdb. what do you think?
The issue is coming from this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we've had the PR open for a while now. duckdb/duckdb-rs#373
No description provided.