Upgrade to duckdb 1.1.3 #399
Conversation
The upgrade script was missing crates/duckdb/Cargo.toml in its sed command, causing a unit test to fail.
|
I'm a little confused about the intent of the failing test.
|
|
I've dug into the error a bit more.
Edit: I tripped up by not flushing. A row is written to the table, thanks to computed-column support getting added to the C api. I've updated the test to reflect this new reality. |
| let conn = Connection::open_in_memory()?; | ||
| conn.execute( | ||
| r"CREATE TABLE foo ( | ||
| foobar TEXT, | ||
| foobar_split TEXT[] AS (split(trim(foobar), ',')) | ||
| foobar_twice TEXT AS (foobar || foobar) |
There was a problem hiding this comment.
Scalar type makes testing using query_row a bit easier (i couldn't figure out how to use query_row for a (String, Vec<String>), got some odd type errors).
andrewhamon
force-pushed
the
upgrade-1-1-3
branch
from
fd92f02 to
9a67eaf
Compare
Prior to duckdb/duckdb#14346, the C API did not support appending to tables with computed columns. This would cause panics until duckdb#296, where a test was introduced asserting that an append to a table with computed columns returns an error value. Now that appending to is supported, update the test to reflect that.
andrewhamon
force-pushed
the
upgrade-1-1-3
branch
from
9a67eaf to
e01585b
Compare
Hello! I am hacking on a project using duckdb rust and noticed that the duckdb version was slightly out of date.
This came to my attention because it seems like a community plugin I am trying to use does not have updated binaries for duckdb 1.1.1 (the bigquery extension, to be specific).
Also, the upgrade script I think was missing
crates/duckdb/Cargo.toml, so I added that in.